Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stash notifies when using the conditional build step #30

Closed
KyleLNicholls opened this issue Mar 27, 2014 · 3 comments
Closed

Stash notifies when using the conditional build step #30

KyleLNicholls opened this issue Mar 27, 2014 · 3 comments

Comments

@KyleLNicholls
Copy link

I'm using the conditional build step with Stash Notify. If the conditional build step prevents the Stash notification then in Stash I get "build in progress" indefinitely.
Regardless of the conditional build step Stash gets notified at the beginning of a build that it's in progress.

Maybe have the plugin not do the initial notification if conditional build step is being used? Or have an option to not use the initial notification all together?

@michaelajr
Copy link

This is an issue for me as well. My deployment job can run from an upstream build job - and in that case I have the GIT_COMMIT ID. But it can also run manually - pulling down a user-specified version from our maven repo. In this case - I do not have a GIT_COMMIT ID. I'd really love to use the Conditional Build step to determine if I have a GIT_COMMIT ID - and if so - notify Stash. As the OP indicates this does not seem to work because of the "build in progress" notification, which can not be wrapped in a conditional build step. Hoping for an easy fix, like an opt-out of the "build in progress" notification, or recognize that it is part of a conditional build step - and check if the step is enabled before notifying.

@scaytrase
Copy link
Member

I think opt-out pre-build notifying is an options, so closing in favor of #53

@scaytrase
Copy link
Member

You could try latest build to check an option which disables pre-build notification. It's off by default for BC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants