update parent pom, use plugin bom, remove powermock #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
linking jenkinsci/plugin-pom#441 so that this PR is discoverable for anyone else who is struggling with powermock to mockito mockStatic migration 😅 |
|
Related: jenkinsci/plugin-pom#442 This PR is of particular importance for Java 11+ compatibility. |
offa
approved these changes
Dec 20, 2021
powermock tests written using mockito's mockStatic added configuration-as-code test-harness update jenkins.version
|
@scaytrase resolved merge conflict :) |
|
This PR should take care of most dependabot PRs 😄 |
scaytrase
reviewed
Jan 17, 2022
| <relativePath /> | ||
| </parent> | ||
| <packaging>hpi</packaging> | ||
| <properties> | ||
| <revision>1.25</revision> | ||
| <changelist>-SNAPSHOT</changelist> | ||
| <!-- Baseline Jenkins version you use to build the plugin. Users must have this version or newer to run. --> | ||
| <jenkins.version>2.60.3</jenkins.version> | ||
| <jenkins.version>2.303.1</jenkins.version> |
There was a problem hiding this comment.
Just a note for myself. This is an LTE relase 5 months old
There was a problem hiding this comment.
We can drop it down a little with a matching plugin bom
|
jenkinsci/configuration-as-code-plugin#1815 was the reason for this PR to fix plugin loading conflict |
|
thanks @jetersen ! |
|
@scaytrase your welcome! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to latest plugin parent pom.
Added plugin bom to help manage plugin versions for other plugins. You can read more about plugin bom here: https://github.com/jenkinsci/bom
Updated jenkins.version according to https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
Added plugin bom to make it easier to manage the plugin and the dependencies.
Updated JCasC test to use the JCasC test-harness.
replaced all powermock tests with mockito's mockStatic