Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-22778] Revert JENKINS-18574 related changes #78

Merged
merged 2 commits into from
May 1, 2014

Conversation

daniel-beck
Copy link
Member

See discussion at ec606ac and JENKINS-22778 for a description why these commits need to be reverted.

This reverts commit fe0b641.
This reverts commit ec606ac, reversing
changes made to 3f09b1c.

Conflicts:
	src/main/java/hudson/scm/SubversionChangeLogBuilder.java
@daniel-beck
Copy link
Member Author

Only to be merged if no better (JENKINS-18574 compatible) solution for the problems linked above is written.

@cloudbees-pull-request-builder

plugins » subversion-plugin #341 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@kutzi
Copy link
Member

kutzi commented May 1, 2014

Merging as no one - and especially @ndeloof - did raise any concerns on ec606ac

kutzi added a commit that referenced this pull request May 1, 2014
[FIXED JENKINS-22778] Revert JENKINS-18574 related changes
@kutzi kutzi merged commit 929864e into jenkinsci:master May 1, 2014
@kutzi
Copy link
Member

kutzi commented May 1, 2014

@daniel-beck do you think it would be possible to create a unit test which would guard against regressions introduced by later attempts to fix JENKINS-18574 - or other changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants