Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remoting v4 compatibility #180

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Remoting v4 compatibility #180

merged 2 commits into from
Feb 12, 2020

Conversation

offa
Copy link
Contributor

@offa offa commented Feb 12, 2020

Update of remoting to v4.x (#178).

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit 98fe43a into jenkinsci:master Feb 12, 2020
@offa offa deleted the remoting-v4 branch February 12, 2020 16:22
@basil
Copy link
Member

basil commented Feb 13, 2020

FYI, I did some backwards compatibility testing tonight, and the results are good! I tested the full cross product of the following:

Jenkins Masters

  • Jenkins 2.190.3 (Remoting 3.33), Swarm Plugin 3.17 (Remoting 3.30)
  • Jenkins 2.190.3 (Remoting 3.33), Swarm Plugin HEAD (Remoting 4.2)
  • Jenkins 2.220 (Remoting 4.2), Swarm Plugin HEAD (Remoting 4.2)

Swarm Clients

  • Swarm Client 3.17 (Remoting 3.30)
  • Swarm Client HEAD (Remoting 4.2)

All 6 tests were successful. This gives me confidence in the backwards compatibility of these changes.

@basil basil added the dependencies Pull requests that update a dependency file label Feb 13, 2020
@basil
Copy link
Member

basil commented Feb 13, 2020

This was just released in Swarm 3.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants