Extract upload functionality + small cleanups

[lacostej]

The original purpose of the changes was to extract the upload part into a separate class so that I could verify the uploading from the command line.

There are a couple of cleanups as well.

Let me know if you prefer me to split the commits into different pull requests.

[nheagy]

Definitely needs to be separate so that it's clearer what's going on and why.

[lacostej]

Ok.
On Apr 11, 2012 5:35 PM, "Nate Heagy" <
reply@reply.github.com>
wrote:

Definitely needs to be separate so that it's clearer what's going on and
why.

---

Reply to this email directly or view it on GitHub:
#7 (comment)

[lacostej]

I've merged the relevant commits and created branches so that you can see the changes

1. pull from https://github.com/lacostej/testflight-plugin/tree/misc-pom-fixes to get the misc pom fixes
2. pull from https://github.com/lacostej/testflight-plugin/tree/extract-reporter-class to get the reporter class extraction
3. pull from https://github.com/lacostej/testflight-plugin/tree/reporter-class-and-expand-envvars-in-buildnotes (depends on Fixing JENKINS-11917 - Upload files from Jenkins Slaves #2) to also get the envvars expansion for buildnotes.

Is that enough or do you want me to close this pull request and send you pull requests for the invididual branches ?

[lacostej]

Closing this request and sent 3 pulls instead.