Extract upload functionality + small cleanups #7

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
2 participants
@lacostej
Member

lacostej commented Apr 3, 2012

The original purpose of the changes was to extract the upload part into a separate class so that I could verify the uploading from the command line.

There are a couple of cleanups as well.

Let me know if you prefer me to split the commits into different pull requests.

@nheagy

This comment has been minimized.

Show comment
Hide comment
@nheagy

nheagy Apr 11, 2012

Member

Definitely needs to be separate so that it's clearer what's going on and why.

Member

nheagy commented Apr 11, 2012

Definitely needs to be separate so that it's clearer what's going on and why.

@lacostej

This comment has been minimized.

Show comment
Hide comment
@lacostej

lacostej Apr 11, 2012

Member

Ok.
On Apr 11, 2012 5:35 PM, "Nate Heagy" <
reply@reply.github.com>
wrote:

Definitely needs to be separate so that it's clearer what's going on and
why.


Reply to this email directly or view it on GitHub:
#7 (comment)

Member

lacostej commented Apr 11, 2012

Ok.
On Apr 11, 2012 5:35 PM, "Nate Heagy" <
reply@reply.github.com>
wrote:

Definitely needs to be separate so that it's clearer what's going on and
why.


Reply to this email directly or view it on GitHub:
#7 (comment)

@lacostej

This comment has been minimized.

Show comment
Hide comment
@lacostej

lacostej Apr 11, 2012

Member

I've merged the relevant commits and created branches so that you can see the changes

  1. pull from https://github.com/lacostej/testflight-plugin/tree/misc-pom-fixes to get the misc pom fixes
  2. pull from https://github.com/lacostej/testflight-plugin/tree/extract-reporter-class to get the reporter class extraction
  3. pull from https://github.com/lacostej/testflight-plugin/tree/reporter-class-and-expand-envvars-in-buildnotes (depends on #2) to also get the envvars expansion for buildnotes.

Is that enough or do you want me to close this pull request and send you pull requests for the invididual branches ?

Member

lacostej commented Apr 11, 2012

I've merged the relevant commits and created branches so that you can see the changes

  1. pull from https://github.com/lacostej/testflight-plugin/tree/misc-pom-fixes to get the misc pom fixes
  2. pull from https://github.com/lacostej/testflight-plugin/tree/extract-reporter-class to get the reporter class extraction
  3. pull from https://github.com/lacostej/testflight-plugin/tree/reporter-class-and-expand-envvars-in-buildnotes (depends on #2) to also get the envvars expansion for buildnotes.

Is that enough or do you want me to close this pull request and send you pull requests for the invididual branches ?

@lacostej

This comment has been minimized.

Show comment
Hide comment
@lacostej

lacostej May 7, 2012

Member

Closing this request and sent 3 pulls instead.

Member

lacostej commented May 7, 2012

Closing this request and sent 3 pulls instead.

@lacostej lacostej closed this May 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment