Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate formatting #183

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Automate formatting #183

merged 1 commit into from
Jan 6, 2023

Conversation

MarkEWaite
Copy link
Contributor

Automate formatting

Simplify maintenance by automating code formatting and and pom formatting.

Format with mvn spotless:apply.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Jan 6, 2023
@github-actions github-actions bot removed the chore Reduces maintenance effort by changes not directly visible to users label Jan 6, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 6, 2023
View reviewed changes
src/main/java/hudson/plugins/testng/Publisher.java
}

@POST
public FormValidation doCheckFailedFails(@QueryParameter String value) {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check

Potential missing permission check in DescriptorImpl#doCheckFailedFails
src/main/java/hudson/plugins/testng/Publisher.java
}

@POST
public FormValidation doCheckFailedSkips(@QueryParameter String value) {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check

Potential missing permission check in DescriptorImpl#doCheckFailedSkips
src/main/java/hudson/plugins/testng/Publisher.java
}

@POST
public FormValidation doCheckUnstableFails(@QueryParameter String value) {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check

Potential missing permission check in DescriptorImpl#doCheckUnstableFails
src/main/java/hudson/plugins/testng/Publisher.java
}

@POST
public FormValidation doCheckUnstableSkips(@QueryParameter String value) {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check

Potential missing permission check in DescriptorImpl#doCheckUnstableSkips
src/main/java/hudson/plugins/testng/TestNGProjectAction.java
if (newGraphNotNeeded(req, rsp)) {
return;
}
public void doGraphMap(final StaplerRequest req, StaplerResponse rsp) throws IOException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check

Potential missing permission check in TestNGProjectAction#doGraphMap
src/main/java/hudson/plugins/testng/TestNGProjectAction.java
* @throws IOException -
*/
// @org.kohsuke.stapler.verb.POST // POST blocks graph rendering in groovy web page
public void doGraph(final StaplerRequest req, StaplerResponse rsp) throws IOException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check

Potential missing permission check in TestNGProjectAction#doGraph
src/main/java/hudson/plugins/testng/TestNGProjectAction.java
if (newGraphNotNeeded(req, rsp)) {
return;
}
public void doGraphMap(final StaplerRequest req, StaplerResponse rsp) throws IOException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation

Potential CSRF vulnerability: If TestNGProjectAction#doGraphMap connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
src/main/java/hudson/plugins/testng/TestNGProjectAction.java
* @throws IOException -
*/
// @org.kohsuke.stapler.verb.POST // POST blocks graph rendering in groovy web page
public void doGraph(final StaplerRequest req, StaplerResponse rsp) throws IOException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation

Potential CSRF vulnerability: If TestNGProjectAction#doGraph connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
@MarkEWaite MarkEWaite merged commit 9e84ff6 into jenkinsci:master Jan 6, 2023
@MarkEWaite MarkEWaite deleted the automate-code-formatting branch January 6, 2023 23:39
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkEWaite