Reduce applicability requirements

[dsavenko]

Hi,

We have a project type, which does not extend AbstractProject, but directly extends Job and implements Queue.Task (we have certain reasons to not extend AbstractProject). We would like to have the Throttle plugin working with it, but it's tied to AbstractProject.

This pull request unties it from AbstractProject class and makes so, that the Throttle plugin works with any class which extends Job and implements Queue.Task.

This is just a technical patch, no new features added.

[oleg-nenashev]

Please avoid such formatting changes to simplify merges

[dsavenko]

Sure, I will get rid of them. Actually, I removed them manually before commit, but IDE put them again :)

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[jglick]

You probably want to implement ParameterizedJobMixIn.ParameterizedJob and have TCB look for that instead.

[dsavenko]

Good point, I haven't thought about it. Will provide the update soon.

[dsavenko]

@jglick, hmm... On second thought, ParameterizedJobMixIn is there since 1.556, while TCB is built against 1.424. Also, JobProperty's generic parameter must extend Job, so I'm bound to extend the ThrottleJobProperty class from JobProperty < Job > (can't use ParameterizedJobMixIn.ParameterizedJob, as it doesn't extend Job).

[oleg-nenashev]

Personally I don't like the SometihgMixIn approach much, because it mostly workarounds Java's inheritance mechanism. It does not mean I can propose a better solution...

ParameterizedJobMixIn.ParameterizedJob is also not guaranteed to be used by all Job implementations, so I'd prefer the current approach.

In any case, the core dependency update may be reasonable. Versions 1.535...1.609.2 do not behave reliably, so probably bumping to 1.609.2 is the best option. The plugin needs some redesign, so please do not consider the version dependency as a blocker.

[dsavenko]

So, what should I do next?

[abayer]

Dependency update is perfectly fine, yeah.

[abayer]

fwiw, tested this and it works fine throttling groups of Workflow jobs - not being used within the Workflow script, though. That's more work, which I'll get diving into once this is in.

[oleg-nenashev]

👍 for the current implementation

[abayer]

Rightie-o, then I'll merge it.

[dsavenko]

Thanks for merging!