New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-63971] prepare for casc support of node monitors #189
Conversation
to support node monitors in casc, is is essential that they have DataBoundConstructors defined and a proper symbol is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. Thanks very much. I need to test it before I merge it. That may take a few days because I am currently traveling and won't return until the end of the week.
Thanks as well. Adding JCasC support for for nodeMonitor is a must. I was testing similar changes when implementing #192 and I confirm changes in the descriptor behave as expected |
I've confirmed that with the configuration as code pull request and this pull request, I see the configuration as code entries. The configuration as code pull request is required before the results of this pull request will be visible to users. |
I've marked this pull request as a draft because the required pull configuration as code pull request is a draft. |
@MarkEWaite can this be merged now? |
Yes. Thanks for the pull request @mawinter69 ! |
to support node monitors in casc, is is essential that they have DataBoundConstructors defined and a proper symbol is used.
Testing done
Tested with jenkinsci/configuration-as-code-plugin#2392 that the monitors are properly exported and can be imported.
export looks like this:
Submitter checklist