Skip to content

Commit

Permalink
[FIXED JENKINS-6623] normal return from the launch method does not ne…
Browse files Browse the repository at this point in the history
…cessarily signify the success.

(even though this is arguably a poor design)
  • Loading branch information
kohsuke committed Mar 9, 2011
1 parent f86c25e commit a77336a
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -82,7 +82,7 @@ protected boolean delegateLaunch(SlaveComputer computer, TaskListener listener)
log(listener, "Starting stage 2 launcher (" + delegate.getClass().getSimpleName() + ")");
getCore().launch(computer, listener);
log(listener, "Stage 2 launcher completed");
return true;
return computer.isOnline();
} catch (IOException e) {
log(listener, "Unable to launch: " + e.getMessage());
return false;
Expand Down

0 comments on commit a77336a

Please sign in to comment.