[JENKINS-25588] - Migrate vSphereCloud to Credentials plugin #16
Conversation
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
| private @Deprecated String vsHost; | ||
| private @Deprecated String username; | ||
| private @Deprecated String password; | ||
| private @Deprecated int maxOnlineSlaves; |
There was a problem hiding this comment.
I'm not sure what these fields do. They seem to be a legacy stuff
|
My apologies - the email notifying of this pull request got routed to my spam folder. This change looks good. Like you mention, it will require a major upgrade due to the change in credentials. |
[JENKINS-25588] - Migrate vSphereCloud to Credentials plugin
|
I've just updated to 2.0 plugin but I cannot figure out how to setup the credential store correctly. No matter what I try I get "Username is not specified" when testing the connection, and any VM slave I try to start returns the following errors: |
|
My initial test of this pull request SEEMED to have worked, but when re-ran the tests - i'm getting the same error. @oleg-nenashev Can you confirm the behavior described here? And if so, do you know how to resolve it? |
|
Fixed the validation handler. |
Warning! This is a breaking change. A new major version (or a significant modification) are required
Signed-off-by: Oleg Nenashev o.v.nenashev@gmail.com