[JENKINS-25588] - Fixed the "Test Connection" validation handler

[oleg-nenashev]

Fixes the error with vSphere validation handlers (caused by #16 )

Signed-off-by: Oleg Nenashev o.v.nenashev@gmail.com

[jswager]

@oleg-nenashev This resolves the "Test Connection" button from the main Jenkins config screen. But this doesn't solve the "no protocol: null/sdk" error when a slave is being started.

Quick look at the debugger: in vSphereCloud.java, in the vSphereInstance() method - both vsHost and username are null - which results in an invalid URL, which might explain this problem.

[oleg-nenashev]

@jswager
Yes, my bad. I have not forced null values in readResolve() and I missed such issues during the testing of the initial PR. In new commits I removed all usages of all variables. Hopefully, the change works now.

[jswager]

@oleg-nenashev This last round of changes does seem to fix everything. The test buttons are working from the main config, slave config, and build steps. A slave can be powered on now.

Thanks for your quick responses and effort on getting these issues resolved so quickly.

[oleg-nenashev]

@jswager
Thank you too for the testing and reviews.
It was my error at the end of the day, so I apologize for inconveniences it cased.