Merge pull request #1690 from jenkinsci/remove-isBlameDisabled

Use the correct property name `skipBlames`
jenkinsci · Feb 28, 2024 · 1aa3487 · 1aa3487
2 parents 694fd8b + 0db1054
commit 1aa3487
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/ScanForIssuesStep.java b/plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/ScanForIssuesStep.java
@@ -120,11 +120,23 @@ public String getScm() {
      *
      * @return {@code true} if SCM blaming should be disabled
      */
-    @SuppressWarnings("PMD.BooleanGetMethodName")
-    public boolean getBlameDisabled() {
+    public boolean isSkipBlames() {
         return isBlameDisabled;
     }
 
+    @DataBoundSetter
+    public void setSkipBlames(final boolean skipBlames) {
+        isBlameDisabled = skipBlames;
+    }
+
+    /**
+     * Sets whether SCM blaming should be disabled.
+     *
+     * @param blameDisabled
+     *         {@code true} if SCM blaming should be disabled
+     * @deprecated use {@link #setSkipBlames(boolean)} instead
+     */
+    @Deprecated
     @DataBoundSetter
     public void setBlameDisabled(final boolean blameDisabled) {
         isBlameDisabled = blameDisabled;
@@ -233,7 +245,7 @@ static class Execution extends AnalysisExecution<AnnotatedReport> {
 
             tool = step.getTool();
             sourceCodeEncoding = step.getSourceCodeEncoding();
-            isBlameDisabled = step.getBlameDisabled();
+            isBlameDisabled = step.isSkipBlames();
             filters = step.getFilters();
             sourceDirectories = step.getAllSourceDirectories();
             sourceCodeRetention = step.getSourceCodeRetention();