Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new build status icons for quality gate status #1092

Merged
merged 12 commits into from
Nov 3, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Nov 1, 2021

Moved the whole Java based summary rendering code to the client side. So we can apply CSS styling in a simpler way.

Examples of the new summary:

Bildschirmfoto 2021-11-01 um 23 40 24

Bildschirmfoto 2021-11-03 um 15 56 45

Bildschirmfoto 2021-11-03 um 15 55 52

Moved the whole Java based summary rendering code to the client side.
So we can apply CSS styling in a simpler way.
@uhafner uhafner added the bug Bugs or performance problems label Nov 1, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1092 (039c649) into master (770be8d) will increase coverage by 79.71%.
The diff coverage is 77.55%.

❗ Current head 039c649 differs from pull request most recent head 72cd036. Consider uploading reports for the commit 72cd036 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1092       +/-   ##
=============================================
+ Coverage          0   79.71%   +79.71%     
- Complexity        0     1474     +1474     
=============================================
  Files             0      242      +242     
  Lines             0     5373     +5373     
  Branches          0      422      +422     
=============================================
+ Hits              0     4283     +4283     
- Misses            0      933      +933     
- Partials          0      157      +157     
Impacted Files Coverage Δ
...kins/plugins/analysis/core/model/IssuesDetail.java 52.47% <ø> (ø)
...kins/plugins/analysis/core/model/ResultAction.java 59.61% <0.00%> (ø)
...is/core/portlets/PullRequestMonitoringPortlet.java 71.05% <ø> (ø)
...jenkins/plugins/analysis/core/restapi/ToolApi.java 88.23% <ø> (ø)
...s/plugins/analysis/core/util/IssuesStatistics.java 93.02% <ø> (ø)
...enkins/plugins/analysis/core/util/QualityGate.java 50.48% <ø> (ø)
.../plugins/analysis/core/util/QualityGateStatus.java 92.85% <0.00%> (ø)
...lugins/analysis/warnings/DuplicateCodeScanner.java 82.79% <ø> (ø)
...ins/plugins/analysis/warnings/tasks/OpenTasks.java 40.25% <ø> (ø)
...gins/analysis/core/model/SvgIconLabelProvider.java 55.55% <55.55%> (ø)
... and 244 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 770be8d...72cd036. Read the comment docs.

@uhafner uhafner marked this pull request as ready for review November 3, 2021 14:06
@uhafner uhafner merged commit 4f55745 into master Nov 3, 2021
@uhafner uhafner deleted the status-icons-for-portlet branch November 3, 2021 16:22
uhafner added a commit to uhafner/jenkins that referenced this pull request Nov 5, 2021
uhafner added a commit to uhafner/jenkins that referenced this pull request Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
1 participant