Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWASP dependency check issue parser #1117

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

sirius94
Copy link

@sirius94 sirius94 commented Nov 18, 2021

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

This PR is a continuation of jenkinsci/analysis-model#708 and depends on #1115

@KalleOlaviNiemitalo
Copy link
Contributor

I assume this does not have the same SECURITY-2488 XXE vulnerability as the OWASP Dependency-Check plugin.

}

/** Descriptor for this static analysis tool. */
@Symbol("owaspDependencyCheck")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if this ID is not already used by the original OwaspDependencyCheck plugin?

Copy link
Contributor

@KalleOlaviNiemitalo KalleOlaviNiemitalo Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uhafner
Copy link
Member

uhafner commented Nov 18, 2021

I assume this does not have the same SECURITY-2488 XXE vulnerability as the OWASP Dependency-Check plugin.

Actually the parser uses JSON. (And all parsers in the warnings plugin correctly use a safe parser: https://github.com/jenkinsci/analysis-model/blob/master/src/main/java/edu/hm/hafner/analysis/SecureXmlParserFactory.java))

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #1117 (1d616f0) into master (15e65c4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1117      +/-   ##
============================================
+ Coverage     79.72%   79.74%   +0.01%     
- Complexity     1476     1477       +1     
============================================
  Files           243      244       +1     
  Lines          5372     5376       +4     
  Branches        420      420              
============================================
+ Hits           4283     4287       +4     
  Misses          933      933              
  Partials        156      156              
Impacted Files Coverage Δ
...lugins/analysis/warnings/OwaspDependencyCheck.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e65c4...1d616f0. Read the comment docs.

@uhafner
Copy link
Member

uhafner commented Nov 19, 2021

Do not use force push after we made a review. Otherwise it is hard to see what changed since the review.

@uhafner uhafner merged commit d90b48c into jenkinsci:master Nov 19, 2021
@sirius94 sirius94 deleted the add-owasp-dependency-checker branch November 19, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants