Use new messages dialog and improve associated icon link #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plugin/pom.xml
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
============================================
+ Coverage 79.74% 79.78% +0.04%
- Complexity 1477 1479 +2
============================================
Files 244 244
Lines 5376 5377 +1
Branches 420 420
============================================
+ Hits 4287 4290 +3
+ Misses 933 931 -2
Partials 156 156
Continue to review full report at Codecov.
|
Due to changed CSS classes the existing logic needed to be replaced. Now we can detect the error or warnings status by inspecting a CSS class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new messages dialog of the bootstrap plugin that has been introduced with jenkinsci/bootstrap5-api-plugin#65. Additionally use the new icon button introduced with jenkinsci/font-awesome-api-plugin#118. This new button uses the restyled tooltips that have been introduced in Jenkins 2.318 (jenkinsci/jenkins#5763).