Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugin to be included in BOM #1462

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Allow plugin to be included in BOM #1462

merged 1 commit into from
Mar 3, 2023

Conversation

basil
Copy link
Member

@basil basil commented Mar 2, 2023

When attempting to add this plugin to jenkinsci/bom, I received the following error when testing locally against the megawar:

[ERROR]   ConfigurationAsCodeITest.shouldCreateFreestyleJobUsingJobDsl:108->configureJenkins:134 » NoClassDefFound org/jenkinsci/plugins/configfiles/GlobalConfigFiles
[ERROR]   ConfigurationAsCodeITest.shouldFreestyleJobWithSpotBugsUsingJobDsl:69->configureJenkins:134 » NoClassDefFound org/jenkinsci/plugins/configfiles/GlobalConfigFiles
[ERROR]   ConfigurationAsCodeITest.shouldFreestyleJobWithTaskScannerUsingJobDsl:86->configureJenkins:134 » NoClassDefFound org/jenkinsci/plugins/configfiles/GlobalConfigFiles
[ERROR]   JobDslITest.shouldCreateFreestyleJobUsingJobDslAndVerifyIssueRecorderWithDefaultConfiguration:36->configureJenkins:126 » NoClassDefFound org/jenkinsci/plugins/configfiles/GlobalConfigFiles
[ERROR]   JobDslITest.shouldCreateFreestyleJobUsingJobDslAndVerifyIssueRecorderWithValuesSet:78->configureJenkins:126 » NoClassDefFound org/jenkinsci/plugins/configfiles/GlobalConfigFiles

This is a known issue that we have seen when adding other plugins to the BOM, and we have applied the same workaround in each case. Applying the usual workaround to this plugin chased away the issue as expected in my local testing, enabling this plugin to be added to jenkinsci/bom.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #1462 (4ca600a) into master (83c68a0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1462   +/-   ##
=========================================
  Coverage     80.53%   80.53%           
  Complexity     1475     1475           
=========================================
  Files           254      254           
  Lines          5647     5647           
  Branches        426      426           
=========================================
  Hits           4548     4548           
  Misses          947      947           
  Partials        152      152           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uhafner uhafner added bug Bugs or performance problems tests Enhancement of tests and removed bug Bugs or performance problems labels Mar 3, 2023
@uhafner uhafner merged commit b6cf078 into jenkinsci:master Mar 3, 2023
@basil basil deleted the bom branch March 3, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Enhancement of tests
Projects
None yet
2 participants