Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #1616

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Cleanup #1616

merged 2 commits into from
Nov 17, 2023

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Nov 3, 2023

Replace @Generated from the Jakarta package with my own version of @Generated in AssertJ generated code.

Additional cleanup:

  • Update CI actions to use Java 17 and 21 with Maven 3.9.5.
  • Enable autogeneration of dependency graph
  • Replace Jenkins @Issue annotation with the JUnit one

@uhafner uhafner added the internal Internal changes without user or API impact label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1616 (73a3ed6) into master (a34142a) will increase coverage by 0.18%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1616      +/-   ##
============================================
+ Coverage     81.80%   81.99%   +0.18%     
- Complexity     1407     1411       +4     
============================================
  Files           249      249              
  Lines          5353     5353              
  Branches        397      397              
============================================
+ Hits           4379     4389      +10     
+ Misses          856      848       -8     
+ Partials        118      116       -2     

see 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@KalleOlaviNiemitalo
Copy link
Contributor

KalleOlaviNiemitalo commented Nov 4, 2023

Enable autogeneration of dependency graph

I could not find what part of the diff does that. Could you point it out for me? Mainly I'm wondering if that is something I should be using in my own code.

@uhafner
Copy link
Member Author

uhafner commented Nov 4, 2023

The annotations are used in the templates (txt files).

@uhafner
Copy link
Member Author

uhafner commented Nov 4, 2023

Enable autogeneration of dependency graph

I could not find what part of the diff does that. Could you point it out for me? Mainly I'm wondering if that is something I should be using in my own code.

I added this part in the parent pom.

@uhafner
Copy link
Member Author

uhafner commented Nov 4, 2023

I am currently locally testing this for analysis-pom as well: uhafner/codingstyle-pom#655

@uhafner uhafner marked this pull request as draft November 4, 2023 10:04
@uhafner uhafner marked this pull request as ready for review November 17, 2023 21:49
@uhafner uhafner merged commit 3c94786 into master Nov 17, 2023
35 of 36 checks passed
@uhafner uhafner deleted the cleanup branch November 17, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
2 participants