Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use success colour variable rather than hardcoded colour #1661

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

janfaracik
Copy link
Contributor

Uses the Jenkins success colour variable rather than a hardcoded green.

Before
image

After
image

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@janfaracik janfaracik changed the title Use success colour Use success colour variable rather than hardcoded color Jan 14, 2024
@janfaracik janfaracik changed the title Use success colour variable rather than hardcoded color Use success colour variable rather than hardcoded colour Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc2888d) 81.69% compared to head (a4e09a9) 81.78%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1661      +/-   ##
============================================
+ Coverage     81.69%   81.78%   +0.09%     
- Complexity     1413     1415       +2     
============================================
  Files           249      249              
  Lines          5380     5380              
  Branches        403      403              
============================================
+ Hits           4395     4400       +5     
+ Misses          870      866       -4     
+ Partials        115      114       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner added the bug Bugs or performance problems label Jan 14, 2024
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting, I thought that I replaced all colors...

@uhafner uhafner merged commit 9acbee4 into jenkinsci:main Jan 14, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
2 participants