Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icon from reference link as it is broken in core again #1697

Merged
merged 1 commit into from Mar 6, 2024

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Feb 29, 2024

UI visualization of the link is broken again in Jenkins core: JENKINS-72491. So it makes sense to remove the status icon and only show the raw link. When a fix for jenkinsci/jenkins#8705 is available, we can revert that change.

@uhafner uhafner added the bug Bugs or performance problems label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.41%. Comparing base (cb0172f) to head (6a1cbad).

❗ Current head 6a1cbad differs from pull request most recent head 1591ab4. Consider uploading reports for the commit 1591ab4 to get more accurate results

Files Patch % Lines
...kins/plugins/analysis/core/model/SummaryModel.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1697      +/-   ##
============================================
- Coverage     82.54%   82.41%   -0.13%     
+ Complexity     1348     1346       -2     
============================================
  Files           248      248              
  Lines          5202     5204       +2     
  Branches        400      400              
============================================
- Hits           4294     4289       -5     
- Misses          801      807       +6     
- Partials        107      108       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner merged commit a476957 into main Mar 6, 2024
31 of 33 checks passed
@uhafner uhafner deleted the reference-build-link branch March 6, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
1 participant