Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-58826] Fix visible number of build results in charts #226

Merged
merged 4 commits into from Oct 3, 2019

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Oct 2, 2019

See JENKINS-58826.

The number of builds which are included into a trend chart is currently limited by the fixed number of 50 builds. This limit is currently only working correctly in single trend charts. In aggregations (and charts with days as domain axis), this limit is applied on the wrong side, i.e. the charts are showing the first 50 builds and not the last 50 builds.

@uhafner uhafner added the bug Bugs or performance problems label Oct 2, 2019
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #226   +/-   ##
=========================================
  Coverage     82.68%   82.68%           
  Complexity     1582     1582           
=========================================
  Files           247      247           
  Lines          5411     5411           
  Branches        388      388           
=========================================
  Hits           4474     4474           
  Misses          786      786           
  Partials        151      151
Impacted Files Coverage Δ Complexity Δ
.../plugins/analysis/core/charts/CompositeResult.java 76.66% <100%> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c090343...d48e28b. Read the comment docs.

@jenkinsci jenkinsci deleted a comment Oct 3, 2019
@jenkinsci jenkinsci deleted a comment Oct 3, 2019
@jenkinsci jenkinsci deleted a comment Oct 3, 2019
@jenkinsci jenkinsci deleted a comment Oct 3, 2019
@uhafner uhafner merged commit 4371075 into master Oct 3, 2019
@uhafner uhafner deleted the JENKINS-58826-build-iterator-order branch October 3, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
1 participant