Move UI tests from ATH to plugin

[uhafner]

See jenkinsci/acceptance-test-harness#556

And some other examples:

• Move ath to module to escape the dependency hell kerberos-sso-plugin#19
• Move ath to module to escape the dependency hell openstack-cloud-plugin#288
• Move ath to module to escape the dependency hell jms-messaging-plugin#164

[codecov]

Codecov Report

Merging #396 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #396      +/-   ##
============================================
+ Coverage     81.88%   81.95%   +0.07%     
+ Complexity     1499     1497       -2     
============================================
  Files           235      234       -1     
  Lines          5206     5199       -7     
  Branches        355      355              
============================================
- Hits           4263     4261       -2     
+ Misses          795      790       -5     
  Partials        148      148

Impacted Files	Coverage Δ	Complexity Δ
...kins/plugins/analysis/core/model/IssuesDetail.java	82.95% <ø> (ø)	40 <0> (ø)	⬇️
...lugins/analysis/warnings/DuplicateCodeScanner.java	87.95% <ø> (ø)	6 <0> (ø)	⬇️
...jenkins/plugins/analysis/core/model/JobAction.java	67.64% <ø> (ø)	15 <0> (ø)	⬇️
...ins/analysis/core/portlets/IssuesChartPortlet.java	6.45% <ø> (ø)	0 <0> (ø)	⬇️
...ins/analysis/core/model/AggregatedTrendAction.java	35.55% <ø> (ø)	7 <0> (ø)	⬇️
...s/plugins/analysis/core/model/ReportXmlStream.java	95.65% <100%> (+0.19%)	3 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f50c1a...740893b. Read the comment docs.

[uhafner]

Here is an overview of what got changed by this pull request:

Issues
======
- Added 45
           

Complexity increasing per file
==============================
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/AnalysisSummary.java  4
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/AbstractNonDetailsIssuesTableRow.java  4
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/IssuesTable.java  3
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/DryIssuesTableRow.java  5
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/ConsoleLogView.java  1
- plugin/src/test/java/io/jenkins/plugins/analysis/core/model/ReportXmlStreamTest.java  3
- plugin/src/main/java/io/jenkins/plugins/analysis/core/model/JobAction.java  2
- plugin/src/main/java/io/jenkins/plugins/analysis/core/model/ReportXmlStream.java  3
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/InfoView.java  2
- ui-tests/src/test/resources/source-view/SampleClassWithNestedAndNormalNamespace.cs  1
- plugin/src/main/java/io/jenkins/plugins/analysis/core/portlets/IssuesChartPortlet.java  1
- plugin/src/main/java/io/jenkins/plugins/analysis/warnings/DuplicateCodeScanner.java  2
- ui-tests/src/test/resources/source-view/SampleClassWithNamespaceBetweenCode.cs  1
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/AnalysisResult.java  4
- ui-tests/src/test/java/io/jenkins/plugins/analysis/warnings/WarningsNextGenerationPluginTest.java  3
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/IssuesRecorder.java  3
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/AbstractIssuesTableRow.java  1
- plugin/src/test/java/io/jenkins/plugins/analysis/warnings/DryTableModelTest.java  2
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/TableView.java  1
- plugin/src/main/java/io/jenkins/plugins/analysis/core/model/AggregatedTrendAction.java  4
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/DefaultWarningsTableRow.java  5
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/ScrollerUtil.java  1
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/SourceView.java  3
- ui-tests/src/main/java/io/jenkins/plugins/analysis/warnings/DetailsTableRow.java  1
- plugin/src/main/java/io/jenkins/plugins/analysis/core/model/IssuesDetail.java  5
         

See the complete overview on Codacy

[uhafner]

@olivergondza I am almost there 👍 Now 4 tests are working! (One tests fails due to the maven version that I fixed in jenkinsci/acceptance-test-harness#563).

The remaining test that does not work yet is https://ci.jenkins.io/job/Plugins/job/warnings-ng-plugin/job/ui-tests/lastCompletedBuild/testReport/io.jenkins.plugins.analysis.warnings/WarningsNextGenerationPluginTest/linux_8___Archive__linux_8____should_parse_warnings_on_agent/.

This test creates a Jenkins agent in a docker container, but docker is not installed in the Firefox-container image. Can we add docker to that container as well? Or does docker in docker not work properly?

[olivergondza]

@uhafner, note using the firefox-container runs the browser inside, but surefire and Jenkins are out of the container - hence I believe docker-in-docker is not the issue here as it is being launched by the surefire process. Since you have custom Jenkinsfile, can you archive target/diagnostics/ to access the container logs after the failure?

[uhafner]

Superseded by #419