Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layout of checks markup #724

Merged
merged 9 commits into from Dec 30, 2020
Merged

Improve layout of checks markup #724

merged 9 commits into from Dec 30, 2020

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Dec 28, 2020

Improves several aspects of the checks layout:

  • Use a more compact layout for the summary and details pane using tables.
  • Add a trend emoji indicator that shows if the project is improving or not.
  • Show the reference build that is used to compute the new warnings.
  • Add an optional option to show all warnings as annotations (and not only the new ones)

@uhafner uhafner added the enhancement Enhancement of existing functionality label Dec 28, 2020
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #724 (9c1dcce) into master (f641419) will increase coverage by 0.09%.
The diff coverage is 94.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #724      +/-   ##
============================================
+ Coverage     79.63%   79.73%   +0.09%     
- Complexity     1506     1521      +15     
============================================
  Files           241      241              
  Lines          5520     5560      +40     
  Branches        403      409       +6     
============================================
+ Hits           4396     4433      +37     
- Misses          962      964       +2     
- Partials        162      163       +1     
Impacted Files Coverage Δ Complexity Δ
...plugins/analysis/core/steps/PublishIssuesStep.java 56.79% <40.00%> (-0.81%) 30.00 <1.00> (+1.00) ⬇️
...ns/plugins/analysis/core/steps/IssuesRecorder.java 67.87% <100.00%> (+0.52%) 83.00 <2.00> (+3.00)
.../plugins/analysis/core/steps/RecordIssuesStep.java 56.18% <100.00%> (+0.92%) 42.00 <2.00> (+2.00)
...ns/analysis/core/steps/WarningChecksPublisher.java 98.14% <100.00%> (+0.64%) 31.00 <11.00> (+9.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f641419...9c1dcce. Read the comment docs.

# Conflicts:
#	plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/IssuesRecorder.java
#	plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/PublishIssuesStep.java
#	plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/WarningChecksPublisher.java
#	plugin/src/test/java/io/jenkins/plugins/analysis/core/steps/WarningChecksPublisherITest.java
Also add an integration test that verifies the step.
@uhafner uhafner mentioned this pull request Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
1 participant