Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let getDescriptionProvider return a DescriptionProvider instance #877

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Let getDescriptionProvider return a DescriptionProvider instance #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<url>https://github.com/jenkinsci/warnings-ng-plugin</url>

<properties>
<revision>9.1.0</revision>
<revision>9.0.1</revision>
<changelist>-SNAPSHOT</changelist>

<module.name>${project.groupId}.warnings.ng</module.name>
Expand Down Expand Up @@ -670,9 +670,9 @@
</item>
<item>
<regex>true</regex>
<code>java.method.numberOfParametersChanged</code>
<methodName>do[A-Z].*</methodName>
<justification>Validation methods are internal API.</justification>
<code>java.method.returnTypeChanged</code>
<methodName>getDescriptionProvider</methodName>
<justification>Return type must be part of the API.</justification>
</item>
<item>
<code>java.method.added</code>
Expand Down
2 changes: 1 addition & 1 deletion plugin/src/main/java/io/jenkins/plugins/analysis/core/model/AnalysisModelParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public StaticAnalysisLabelProvider getLabelProvider() {
*
* @return a description provider
*/
protected RegistryIssueDescriptionProvider getDescriptionProvider() {
protected DescriptionProvider getDescriptionProvider() {
return descriptionProvider;
}

Expand Down