This repository has been archived by the owner on Apr 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 148
Expose methods to allow adding parsers through scripting #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposed the replaceGroovyParsers api for external groovy scripts.
This makes it possible to add new parsers through the script console or on Jenkins start-up.
Does this also mean that #82 can be closed afterwards? |
I assume so, as I kept @naramana's method exposed. We're not affiliated, we just have a common interest in making parsers configurable through scripting. :) |
uhafner
reviewed
Feb 22, 2017
/** | ||
* Adds the given Groovy parser to the configured Groovy parsers | ||
*/ | ||
public void addGroovyParser(GroovyParser parser) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameters should be final
/** | ||
* Adds the given list of Groovy parsers to the configured Groovy parsers | ||
*/ | ||
public void addGroovyParsers(List<GroovyParser> parsers) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final Collection<GroovyParser>
/** | ||
* Replaces the configured Groovy parsers with the given list. | ||
*/ | ||
public void replaceGroovyParsers(List<GroovyParser> parsers) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final Collection<GroovyParser>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to and building on #82.
It'd be great if we could manipulate the configured parsers through the script console or through Jenkins' start-up scripts. I took the existing commit from #82 and added two methods to add a single or multiple parsers.
Pinging @ewelinawilkosz2 as it relates to her current project.