New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optional client certificate #354
Conversation
case "true": | ||
ssl.setNeedClientAuth(true); | ||
break; | ||
case "optional": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this need some update in the help file here https://github.com/jenkinsci/winstone/blob/master/src/main/resources/winstone/LocalStrings.properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far this option is undocumented but I can add it
Co-authored-by: Olivier Lamy <olamy@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mawinter69 Thanks a lot for your contribution. And your patience! ;) |
allow to make the client verification via a certificate optional.
fix #353
Testing done
Submitter checklist