Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional client certificate #354

Merged
merged 5 commits into from Dec 6, 2023
Merged

Conversation

mawinter69
Copy link
Contributor

allow to make the client verification via a certificate optional.

fix #353

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@mawinter69
Copy link
Contributor Author

@basil @olamy
Can you please take a look

@mawinter69
Copy link
Contributor Author

Friendly Reminder @basil @olamy

case "true":
ssl.setNeedClientAuth(true);
break;
case "optional":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far this option is undocumented but I can add it

Co-authored-by: Olivier Lamy <olamy@apache.org>
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olamy olamy merged commit 4019798 into jenkinsci:master Dec 6, 2023
15 checks passed
@olamy
Copy link
Member

olamy commented Dec 6, 2023

@mawinter69 Thanks a lot for your contribution. And your patience! ;)
PR merged and release done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow optional clientauth certificate
2 participants