Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-64438] Implement removeAll on FlowNode actions to support addOrReplaceAction. #133

Merged
merged 3 commits into from
Jan 11, 2021
Merged

[JENKINS-64438] Implement removeAll on FlowNode actions to support addOrReplaceAction. #133

merged 3 commits into from
Jan 11, 2021

Conversation

mrginglymus
Copy link
Contributor

@mrginglymus mrginglymus commented Jan 9, 2021 •
edited
Loading

This fixes https://issues.jenkins.io/browse/JENKINS-64438, which means that addOrReplaceAction on FlowNodes no longer explodes with a UnsupportedOperationException.

timja
timja approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dwnusbaum @bitwiseman

dwnusbaum
dwnusbaum reviewed Jan 11, 2021
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrginglymus Thanks for the PR! Can you please add @Issue to the new test?

src/test/java/org/jenkinsci/plugins/workflow/graph/FlowNodeTest.java Show resolved Hide resolved
@dwnusbaum dwnusbaum changed the title Implement removeAll on FlowNode actions to support addOrReplaceAction. [JENKINS-64438] Implement removeAll on FlowNode actions to support addOrReplaceAction. Jan 11, 2021
@mrginglymus @dwnusbaum
Add @issue reference
02f57ed 
Co-authored-by: Devin Nusbaum <dwnusbaum@users.noreply.github.com>
dwnusbaum
dwnusbaum approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Once the CI build passes I'll merge this.

@timja
Copy link
Member

timja commented Jan 11, 2021

Thanks! Once the CI build passes I'll merge this.

you could enable auto-complete in the repo settings 😉

@dwnusbaum dwnusbaum merged commit 7309be0 into jenkinsci:master Jan 11, 2021
@mrginglymus mrginglymus deleted the implement-remove-all branch January 11, 2021 19:22
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@dwnusbaum dwnusbaum dwnusbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrginglymus @timja @dwnusbaum