Revert fixes related to JENKINS-67351 and JENKINS-67164 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e cases (jenkinsci#188)" This reverts commit 6d6de20.
…e` (jenkinsci#187)" This reverts commit 6a04bac.
…kflowRun.onLoad rather than via FlowExecutionList.ItemListenerImpl to ensure step resumption (jenkinsci#178)" This reverts commit 37c8c49.
dwnusbaum
commented
Jan 14, 2022
src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
Outdated
Show resolved
Hide resolved
jglick
approved these changes
Jan 14, 2022
src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
Outdated
Show resolved
Hide resolved
| @@ -99,113 +79,4 @@ | |||
| }); | |||
| } | |||
|
|
|||
| @Test public void forceLoadRunningExecutionsAfterRestart() throws Throwable { | |||
car-roll
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
@dwnusbaum I can leave it to you to merge if you want to make any additional updates
|
Rebuilding, last build was interrupted for some reason. |
jglick
approved these changes
Jan 18, 2022
src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
Outdated
Show resolved
Hide resolved
jglick
approved these changes
Jan 18, 2022
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #188, #187, and #178 due to problems in #188 (see #188 (comment)) which have no obvious fix.
The
FlowExecutionList.isResumptionCompleteAPI from #188 is preserved to avoid binary compatibility issues withworkflow-durable-task-stepprior to jenkinsci/workflow-durable-task-step-plugin#197.These fixes were generally expected only to apply to uncommon scenarios related to disaster recovery, so I think it is ok to revert them for now.