Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-37400] Allow to use constant variable names for parameters. #44

Closed

Conversation

ikedam
Copy link
Member

@ikedam ikedam commented Aug 16, 2016

JENKINS-37400

I want to use constant values in workflow-cps like

def runWrapper = selectRun job: 'upstream-project-name', 
  selector: status(SUCCESSFUL)

This change requires jenkinsci/structs-plugin#11. Build will fail.

@@ -99,7 +99,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>structs</artifactId>
<version>1.3</version>
<version>1.4-SNAPSHOT</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this requires jenkinsci/structs-plugin#11.

@jglick
Copy link
Member

jglick commented Aug 25, 2016

Build will fail.

mvn -DskipTests deploy dependencies.

@ikedam
Copy link
Member Author

ikedam commented Aug 27, 2016

mvn -DskipTests deploy dependencies.

That means deploying a snapshot release with jenkinsci/structs-plugin#11 to maven.jenkins-ci.org, doesn't it?
I've run a build and a test in my environment by running mvn install.
I don't think it's a good idea to deploy a plugin with local changes even if it's a snapshot release, and I'll do that at least after jenkinsci/structs-plugin#11 is merged.

@jglick
Copy link
Member

jglick commented Sep 7, 2016

That means deploying a snapshot release with jenkinsci/structs-plugin#11 to maven.jenkins-ci.org, doesn't it?

Yes, we do that all the time for chained PRs.

@ikedam
Copy link
Member Author

ikedam commented Sep 10, 2016

Abondon the review.
I'll try another way.

@ikedam ikedam closed this Sep 10, 2016
svanoort pushed a commit that referenced this pull request Sep 28, 2017
…ts-JENKINS-31582

[JENKINS-31582] ArgumentsAction.getResolvedArguments
dwnusbaum pushed a commit to dwnusbaum/workflow-cps-plugin that referenced this pull request Jun 1, 2020
Unset fields at the end of call so we do not hold on to large retained sets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants