Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-27421] Improve behavior of map iteration workaround a bit #77

Merged
merged 2 commits into from Oct 20, 2016

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 20, 2016

JENKINS-27421

Downstream of jenkinsci/script-security-plugin#92.

@reviewbybees

· Pick up new default whitelist entries.
· Use a revised workaround that more closely matches the original syntax.
· Fix the engine to cleanly fail the build with the serialization error, rather than throwing an assertion and hanging.
@abayer
Copy link
Member

abayer commented Oct 20, 2016

🐝

@ghost
Copy link

ghost commented Oct 20, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@stephenc
Copy link
Member

🐝

@svanoort
Copy link
Member

🐝 LGTM assuming tests pass

@raul-arabaolaza
Copy link

🐝

@jglick jglick merged commit a115a54 into jenkinsci:master Oct 20, 2016
@jglick jglick deleted the mapIterator-JENKINS-27421 branch October 20, 2016 15:13
dwnusbaum pushed a commit to dwnusbaum/workflow-cps-plugin that referenced this pull request Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants