Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-34246] Make AbstractWorkflowMultiBranchProjectFactory handle deletion or update of existing children #15

Merged

Conversation

@jglick
Copy link
Member

commented Jun 8, 2016

…handle deletion or update of existing children.
pom.xml Outdated
@@ -84,7 +84,7 @@ THE SOFTWARE.
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>branch-api</artifactId>
<version>1.9</version>
<version>1.10-SNAPSHOT</version> <!-- TODO https://github.com/jenkinsci/branch-api-plugin/pull/45 -->

This comment has been minimized.

Copy link
@jglick

jglick Jun 8, 2016

Author Member

The actual fix is just picking up the dependency.

if (project instanceof WorkflowMultiBranchProject) {
customize((WorkflowMultiBranchProject) project);
} // otherwise got recognized by something else before, oh well
}

This comment has been minimized.

Copy link
@jglick

jglick Jun 8, 2016

Author Member

For use by non-WorkflowMultiBranchProjectFactory subclasses.

sampleRepo2.git("commit", "--message=noflow");
top.scheduleBuild2(0).getFuture().get();
top.getComputation().writeWholeLogTo(System.out);
assertEquals(1, top.getItems().size());

This comment has been minimized.

Copy link
@jglick

jglick Jun 8, 2016

Author Member

The integration test.

@amuniz

This comment has been minimized.

Copy link
Member

commented Jun 9, 2016

🐝

@jglick jglick merged commit c0d0368 into jenkinsci:master Jun 9, 2016
1 check passed
1 check passed
Jenkins This pull request looks good
Details
@jglick jglick deleted the jglick:MultiBranchProjectFactory-update-JENKINS-34246 branch Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.