Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

[WiP] Fixes for StepExecutionIterator #158

Closed

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 27, 2015

JENKINS-26163 appears to be blocking jenkinsci/ssh-agent-plugin#4.

  • a test
  • extend API to somehow indicate running block-scoped executions
  • implement WaitForConditionStepTest.restartDuringDelay
  • make sure TimeoutStepTest checks onResume

@reviewbybees

@jglick
Copy link
Member Author

jglick commented Jul 27, 2015

Conversation with @kohsuke: currently outer StepExecutions are not saved at all. CpsThread.setStep(StepExecution) is fine as is (despite the name a new CpsThread is created for every block step, not just parallel block!), but we need a public final int CpsThread.parentId.

@recena
Copy link
Contributor

recena commented Jul 28, 2015

@jglick I'm working on: make sure TimeoutStepTest checks onResume. Ok?

@jglick
Copy link
Member Author

jglick commented Jul 28, 2015

@recena sure, just need to convert to use RestartableJenkinsRule, reproduce what I suspect is the bug resulting from a failure of onResume to be called, and @Ignore("TODO …") it.

@jglick
Copy link
Member Author

jglick commented Jul 28, 2015

@recena I did not file this as a branch in origin, so you can either file a PR-on-a-PR, or I can push this into the origin repo to make it easier to collaborate.

@jglick
Copy link
Member Author

jglick commented Jul 28, 2015

#161 from an origin branch.

@jglick jglick deleted the StepExecutionIterator-JENKINS-26163 branch July 28, 2015 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants