-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After upgrading Jenkins, the plugin dosen't work anymore #35
Comments
It seems in the changelog of Jenkins the reason for this issue is mentioned: What's new in 2.379 (2022-11-22)
|
@butchyyyy do you have time to investigate this? In any case, pull requests are welcome. |
Thanks for reporting and apologies for the inconvenience. I'll try to come up with a quick fix this week (adding the commons HttpClient dependency). |
FWIW I tried switch to |
Quick fix is to add pom dependency for plugin commons-httpclient3-api (https://plugins.jenkins.io/commons-httpclient3-api/) <dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>commons-httpclient3-api</artifactId>
<version>3.1-3</version>
</dependency> |
I tried add а dependency for plugin commons-httpclient3-api to pom. I builded |
This release of Jenkins just hide the wider apt repositories in Ubuntu, so I hit this bug today when I upgraded. Is there a quick way to fix this locally? I can still in the Commons HttpClient 3.x API Plugin, but that alone doesn't appear sufficient. |
@jamesvl You can pull my fork and execute |
They don't work at the moment: jenkinsci/zulip-plugin#35
They don't work at the moment: jenkinsci/zulip-plugin#35
They don't work at the moment: jenkinsci/zulip-plugin#35
They don't work at the moment: jenkinsci/zulip-plugin#35
They don't work at the moment: jenkinsci/zulip-plugin#35
It doesn't work at the moment anyway. See jenkinsci/zulip-plugin#35
@EvgenyKuzavlev: I used your fork and build it with last maven without problems. After copying the zulip.hpi to plugins/zulip.jpi, the plugin is correctly loaded, but the global configuration and post-build step are not showing up. Any clue? Note: |
@EvgenyKuzavlev
@EvgenyKuzavlev Have you managed to the get the plugin working with the latest LTS Jenkins? |
@butchyyyy you mentioned that you would be looking at this. Any chance to get this fixed? |
@ipikiiskinen @epaul13 I didn't try to use my fork with latest Jenkins, maybe it doesn't work. I am going to update Jenkins and test it later. My env: |
Any news? I can try to make a correction, but my java is rusted, and I don't know maven nor Jenkins dev env... Might not be the most efficient move :) |
I have started working on a new major version, it will:
I have bulk of the work done. I just need to adjust the unit tests and give this a proper test flight before shipping the new version. Will keep you posted. |
^^ The PR is up, all unit and integration tests are passing. There are more or less no functional changes besides the http client migration. The rest is mostly formatting stuff and test migration away from Powermock. I still need to run some manual testing against Jenkins + Zulip before I release this. If anyone has time to also give the branch a quick test and report any issues, it will be much appreciated. Of course feel free to leave comments on the PR as well, it's first Java code I did in ~4 years 🙈 |
I checked out your PR and tested it. I have now access to global configuration and project post-build actions. Great work! At first, I was unable to get any messages, with an error in Jenkins logs:
I had to add my zulip server chain certificate to make it work. On Ubuntu 22.04, it means:
Now I get my jenkins post messages from Jenkins! So this work on Jenkins 2.387.3 on java 11.0.18 on Ubuntu 22.04 To build, for maven/jenkins devenv noobs like me:
with:
|
Thanks a lot for testing it @epaul13! I was also testing on my end today and verified several scenarios including proxy being setup in Jenkins both with and without authentication. I think we are good to go, will most probably do the release tomorrow. |
Resolved in version 2.0.0 |
Good news. For the certificate validation, my bad. I tested on a brand-new container, and my old jenkins is probably ten years old. I just checked and I have the same chain on the old server. So everything' good! |
Thank You @butchyyyy ! ❤️ |
Jenkins and plugins versions report
Environment
What Operating System are you using (both controller, and any agents involved in the problem)?
Jenkins Docker Image.
In
Version 2.378
, everything's fine. But after upgrading toVersion 2.383
, it breaks.It has been tested on both
JDK 11
andJDK 17
.Reproduction steps
Upgrade Jenkins to the latest version.
Expected Results
The message successfully send to Zulip.
Actual Results
The output of Jenkins pipeline, after running
zulipSend message: 'some messages here'
Anything else?
No response
The text was updated successfully, but these errors were encountered: