Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#35)!: update dependencies according new Jenkins version(2.379+) #36

Closed
wants to merge 1 commit into from

Conversation

EvgenyKuzavlev
Copy link

Hello, guys! I made a quick fix of the issue #35. I added а dependency for plugin commons-httpclient3-api to pom. I tested it in my jenkins server(v. 2.386) and it worked successful. Also I updated some dependencies and tests but tests are failed. I don't know how to fix it, I need help.
Pls, review my PR.
Thank you!

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timabbott
Copy link

Awesome, thanks for working on this @EvgenyKuzavlev!

@butchyyyy do you have time to review this?

@butchyyyy
Copy link
Collaborator

Thanks a lot for the effort to migrate to new Java and Jenkins version and apologies for not attending to your PR earlier.

I'm going to close this one for now as the problems were addressed in #38

@butchyyyy butchyyyy closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants