Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DSL #6

Closed
pixie79 opened this issue Feb 2, 2016 · 7 comments
Closed

Support DSL #6

pixie79 opened this issue Feb 2, 2016 · 7 comments

Comments

@pixie79
Copy link

pixie79 commented Feb 2, 2016

Hi,

It would be good if the zulip plugin supported the job-dsl-plugin so that when we build our jobs via DSL we can enable Zulip notifications automatically.

https://github.com/jenkinsci/job-dsl-plugin/wiki/Extending-the-DSL

Thanks

Mark

@DoCode
Copy link

DoCode commented Aug 1, 2018

What about Jenkins Pipeline syntax?

@lfaraone
Copy link

lfaraone commented Aug 2, 2018

What about Jenkins Pipeline syntax?

please open a separate issue on the main https://github.com/zulip/zulip repository

@timabbott
Copy link

@lfaraone why would an issue on zulip/zulip be the right place to ask about Jenkins Pipeline syntax?

I think a separate issue in this project makes more sense, but @DoCode you should provide more clarity about what you're trying to do; I don't think anyone's going to be able to help with such a brief description of your issue.

@timabbott
Copy link

timabbott commented Aug 2, 2018

Back to the original issue: Contributions welcome! This project is a small plugin, so it's a great place to get involved in contributing open source.

@timabbott
Copy link

@DoCode and others: I believe pipeline syntax was added via #8.

@butchyyyy
Copy link
Collaborator

There's no explicit DSL support, but Zulip steps can be used just fine by the dynamically generated DSLs

Example of DSL creating frestyle job using both Zulip Send and Zulip Notification:

job('DSL-Freestyle') {
  steps {
    zulipSend {
      message('Hello DSL!')
      stream('sandbox')
      topic('dsl')
    }
  }
  publishers {
    zulipNotification {
      stream('sandbox')
      topic('dsl')
    }
  }
}

I think we can close this one.

@timabbott
Copy link

Cool. Closing, though should we add a section to the README documentation with that example on how to do job DSLs so it's easy to find?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants