Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds python 3.9 to CI #102

Merged
merged 1 commit into from Nov 18, 2020
Merged

Adds python 3.9 to CI #102

merged 1 commit into from Nov 18, 2020

Conversation

IAlibay
Copy link
Contributor

@IAlibay IAlibay commented Nov 18, 2020

Fixes #101

Changes in this PR

  • Adds py3.9 to CI
  • Updates setup.py's docs accordingly.

@codecov
Copy link

codecov bot commented Nov 18, 2020 •
edited

Codecov Report

Merging #102 (3f2bcb9) into master (9dfd87a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   72.41%   72.41%           
=======================================
  Files          24       24           
  Lines        4143     4143           
=======================================
  Hits         3000     3000           
  Misses       1143     1143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dfd87a...b164c1d. Read the comment docs.

speleo3
speleo3 approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@speleo3 speleo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

orbeckst
orbeckst approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @IAlibay

@sobolevnrm sobolevnrm merged commit 67039aa into jensengroup:master Nov 18, 2020
@IAlibay IAlibay deleted the python3.9 branch November 18, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

@speleo3 speleo3 speleo3 approved these changes

@sobolevnrm sobolevnrm sobolevnrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add python 3.9 to CI?
4 participants
@IAlibay @orbeckst @speleo3 @sobolevnrm