Output performed with loggers. Adds options --no-print. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| parser.add_option("--verbosity", dest="verbosity", action="store_const", | ||
| help="level of printout - not activated yet") | ||
| help="set the parameter file [%default]") | ||
| parser.add_option("-q", "--no-print", dest="verbosity", action="store_const", const=0, default=1, |
There was a problem hiding this comment.
Sorry for late comment, but just noticed this now. This option was renamed from --quiet to --no-print; but --quiet seems like a better name, and matches the -q short option.
Also previously -z was first, and -q was second. In new code -q is first, and -z is second, which makes the history look like there were more changes then there really were. Would be nice to change ordering of these 2 options to simplify the diff.
|
Thanks on your work on this, @tonigi. BTW when doing the merge, I realized github has an option to squash all commits into one during merge - so I used it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in #11 squashed in one commit.