Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PROPKA input file generation optional #59

Merged
merged 10 commits into from
Jun 4, 2020

Conversation

sobolevnrm
Copy link
Collaborator

Fixes #51.

Pull request #50 should be merged first.

Broken into three files to simplify import analysis:

* `calculations.py` - distance calculations and simple math
* `energy.py` - energy calculations
* `hydrogens.py` - hydrogen geometry calculations

Working towards addressing jensengroup#49
Fixes jensengroup#49

Moved I/O into higher level of of code; should make
issue jensengroup#51
easier to resolve
@sobolevnrm sobolevnrm self-assigned this May 31, 2020
@sobolevnrm
Copy link
Collaborator Author

@speleo3 and @orbeckst - can you please look at this and #50 to let me know if we can merge and tag as v3.2?

@sobolevnrm sobolevnrm merged commit 0cb470f into jensengroup:master Jun 4, 2020
@sobolevnrm sobolevnrm deleted the nathan/tempfile branch June 4, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary temp file creation
2 participants