Skip to content
This repository has been archived by the owner on Jan 28, 2024. It is now read-only.

Commit

Permalink
feat: remove Node 16 support
Browse files Browse the repository at this point in the history
  • Loading branch information
jenssimon committed Oct 16, 2023
1 parent 41a159e commit c4a9057
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 27 deletions.
22 changes: 11 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,12 @@ on:
branches: [ main ]

jobs:
pre_job:
uses: jenssimon/gh-workflows/.github/workflows/skip-push-pr-duplicates.yml@v1.0.6

build:
needs: pre_job
if: ${{ needs.pre_job.outputs.needs_run_and_release == 'true' }}
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand All @@ -29,18 +24,23 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'yarn'

- name: Test
run: |
yarn
yarn ci-test
- name: Install dependencies
run: yarn

- name: Lint
run: yarn lint

- name: TypeScript
run: yarn tsc --noEmit

release:
needs: [build]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: '18'
node-version-file: .nvmrc
cache: 'yarn'
- name: Release
env:
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18.18.2
9 changes: 3 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,9 @@
"url": "https://github.com/jenssimon/sfcc-cartridge-integrity-check"
},
"scripts": {
"lint": "eslint --ext .tsx,.ts,.mts,.cts,.jsx,.js,.mjs,.cjs --fix ./",
"lint": "eslint --ext .tsx,.ts,.mts,.cts,.jsx,.js,.mjs,.cjs ./",
"build": "tsc",
"prepare": "npm-run-all build",
"ci-test": "run-s \"ci-test:*\"",
"ci-test:lint": "eslint --ext .tsx,.ts,.mts,.cts,.jsx,.js,.mjs,.cjs ./",
"ci-test:tsc": "tsc --noEmit",
"commit": "cz",
"postinstall": "husky install",
"prepack": "pinst --disable",
Expand All @@ -46,8 +43,8 @@
"devDependencies": {
"@commitlint/cli": "17.8.0",
"@commitlint/config-conventional": "17.8.0",
"@jenssimon/eslint-config-base": "7.2.6",
"@jenssimon/eslint-config-typescript": "5.1.12",
"@jenssimon/eslint-config-base": "7.3.0",
"@jenssimon/eslint-config-typescript": "5.2.0",
"@types/node": "18.18.5",
"@types/shelljs": "0.8.13",
"commitizen": "4.3.0",
Expand Down
20 changes: 10 additions & 10 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -461,9 +461,9 @@ __metadata:
languageName: node
linkType: hard

"@jenssimon/eslint-config-base@npm:7.2.6":
version: 7.2.6
resolution: "@jenssimon/eslint-config-base@npm:7.2.6"
"@jenssimon/eslint-config-base@npm:7.3.0":
version: 7.3.0
resolution: "@jenssimon/eslint-config-base@npm:7.3.0"
dependencies:
eslint-config-airbnb: ^19.0.4
eslint-config-airbnb-base: ^15.0.0
Expand All @@ -485,21 +485,21 @@ __metadata:
eslint-plugin-wc: ^2.0.0
peerDependencies:
eslint: ^7.32.0 || ^8.2.0
checksum: d6f300c42ce7a24de2f8119e73ec1380d3ebefff3d9f3a13275e3ece42a957f541969f7b8d9829ea8c9b89ff14333a29bb1321336f8c64d85dc9495f75d0995c
checksum: 00fb7b93806d131845a3208325f254e7a9dbfc85171a85ef869fdea81d6e25a0cb57f68e8db59c75faf2a018cdda129f28abda9a6d8dd841fd7b328f1a74499e
languageName: node
linkType: hard

"@jenssimon/eslint-config-typescript@npm:5.1.12":
version: 5.1.12
resolution: "@jenssimon/eslint-config-typescript@npm:5.1.12"
"@jenssimon/eslint-config-typescript@npm:5.2.0":
version: 5.2.0
resolution: "@jenssimon/eslint-config-typescript@npm:5.2.0"
dependencies:
"@typescript-eslint/eslint-plugin": ^6.3.0
"@typescript-eslint/parser": ^6.3.0
eslint-plugin-deprecation: ^2.0.0
peerDependencies:
eslint: ^7.0.0 || ^8.0.0
typescript: ">=4.0.0"
checksum: 150d74525ea4598f9433cdf4a799f6243350bb12bba800ba4a5f392ef8f950e5753d35aef58913a5a813c24bd973887f4976f87c2a893e95265005926df1b7d6
checksum: 2c4eebcbb08934d52de5f7bed64724aea691a5fa42f79d390e0e32d628f3435bf35eb21533ff4bf5317d8e4cca8a461a7b70ffe4df08cfccec44dcd8643a0bb1
languageName: node
linkType: hard

Expand Down Expand Up @@ -8289,8 +8289,8 @@ __metadata:
dependencies:
"@commitlint/cli": 17.8.0
"@commitlint/config-conventional": 17.8.0
"@jenssimon/eslint-config-base": 7.2.6
"@jenssimon/eslint-config-typescript": 5.1.12
"@jenssimon/eslint-config-base": 7.3.0
"@jenssimon/eslint-config-typescript": 5.2.0
"@types/node": 18.18.5
"@types/shelljs": 0.8.13
chalk: ^5.0.1
Expand Down

0 comments on commit c4a9057

Please sign in to comment.