Change default web root to sabnzbd #2
Conversation
| @@ -11,7 +11,7 @@ def __init__(self, base_url, api_key, web_root=None, | |||
| if web_root is not None: | |||
| web_root = '{}/'.format(web_root.strip('/')) | |||
| else: | |||
| web_root = '' | |||
| web_root = 'sabnzbd' | |||
There was a problem hiding this comment.
Did you test this change? Just looking at it, this will create a url like http://host/sabnzbdapi.
There was a problem hiding this comment.
Yes, locally, however I notice now the version on pypi is not the same as the latest version on github (one commit behind) which means I was looking at one version on my machine and making changes to another; this pull request is meaningless. Sorry for taking up your time, it was a long day and it explains why I was so confused haha
I will download the latest version from git instead and see if that fixes things.
There was a problem hiding this comment.
Sounds good. I will get the new version on PyPi today so it can be updated in home assistant too
|
I'm not sure this is the right approach here. SABnzbd responds to api calls at |
Sabnzbd uses /sabnzbd/ as the default
web_root, so it would make sense to change the default behaviour of this library to reflect that. Additionally, an emptyweb_rootwill error out because it produces a malformed url:http://hostname:8080//apias opposed to the expectedhttp://hostname:8080/api. For reference, the default sabnzbd api url ishttp://hostname:8080/sabnzbd/api.