Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default web root to sabnzbd #2

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pysabnzbd/__init__.py
Expand Up @@ -11,7 +11,7 @@ def __init__(self, base_url, api_key, web_root=None,
if web_root is not None:
web_root = '{}/'.format(web_root.strip('/'))
else:
web_root = ''
web_root = 'sabnzbd'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this change? Just looking at it, this will create a url like http://host/sabnzbdapi.

Copy link
Author

@arlyon arlyon Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, locally, however I notice now the version on pypi is not the same as the latest version on github (one commit behind) which means I was looking at one version on my machine and making changes to another; this pull request is meaningless. Sorry for taking up your time, it was a long day and it explains why I was so confused haha

I will download the latest version from git instead and see if that fixes things.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I will get the new version on PyPi today so it can be updated in home assistant too


self.queue = {}
self._api_url = '{}/{}{}'.format(base_url.rstrip('/'), web_root, 'api')
Expand Down