Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not working as of April 2019 #7

Closed
darthwalsh opened this issue Apr 20, 2019 · 0 comments · Fixed by #8
Closed

Not working as of April 2019 #7

darthwalsh opened this issue Apr 20, 2019 · 0 comments · Fixed by #8

Comments

@darthwalsh
Copy link
Collaborator

Not working for me, somebody else had this issue too.

In the chrome debugger on content.js:97, hnq.querySelector('a.show-more') is returning null which causes an error:

content.js:124 TypeError: Cannot read property 'dataset' of null
at content.js:97
@jeremyBanks jeremyBanks mentioned this issue Apr 27, 2019
Merged
jeremyBanks pushed a commit that referenced this issue Apr 27, 2019
@darthwalsh @jeremyBanks
Handle ShowMore link missing
4136117 
The StackOverflow HNQ used to have a "more hot qustions" link, but that
isn't showing now, which breaks the content hiding.

Only try to hide the link if it's present.

Fixes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle ShowMore link missing
1 participant
@darthwalsh