Skip to content
This repository has been archived by the owner on Aug 6, 2021. It is now read-only.

Reevaluate all used Nightly Rust features #228

Closed
jeremyBanks opened this issue Feb 8, 2020 · 2 comments
Closed

Reevaluate all used Nightly Rust features #228

jeremyBanks opened this issue Feb 8, 2020 · 2 comments
Milestone
v0.21.6

Comments

@jeremyBanks
Copy link
Owner

No description provided.

@jeremyBanks jeremyBanks added this to the v0.21.06 milestone Feb 8, 2020
@jeremyBanks jeremyBanks changed the title Stop using Nightly rust Eliminate or reduce use of Nightly Rust Feb 8, 2020
@jeremyBanks jeremyBanks changed the title Eliminate or reduce use of Nightly Rust Reevaluate all used Nightly Rust features Feb 13, 2020
@jeremyBanks
Copy link
Owner Author

jeremyBanks commented Feb 14, 2020 •
edited
Loading

  • arbitrary_self_types: Keep. Very cool, and very likely to land in a compatible way. Some instances may be unnecessary, though.
  • associated_type_defaults: unused. Also, "The existing behavior under #![feature(associated_type_defaults)] is buggy and does not conform to the new RFC. "
  • proc_macro_hygiene: unused
  • slice_concat_ext: unused
  • option_unwrap_none: Keep, will probably be stabilized.
  • never_type: Keep, I like using the syntax and my simple use probably won't be broken during stabilization.
  • try_blocks: Stop using! It sounds like the feature is sort-of abandoned and has an unclear future, and we're only using it minimally in one location.

jeremyBanks added a commit that referenced this issue Feb 14, 2020
@jeremyBanks
Reduce use of Nightly features.
a9cde85 
resolves #228
jeremyBanks added a commit that referenced this issue Feb 14, 2020
@jeremyBanks
Reduce use of Nightly features.
2303e4a 
resolves #228
github-actions bot pushed a commit that referenced this issue Feb 15, 2020
@jeremyBanks
collapse top padding if there's no room for side padding
b5f11d1 
Reduce use of Nightly features.

resolves #228
@jeremyBanks jeremyBanks reopened this Feb 22, 2020
@jeremyBanks
Copy link
Owner Author

jeremyBanks commented Feb 22, 2020 •
edited
Loading

While listening to Rustacean Station 13: What's New in Rust 1.41 (rustacean-station/rustacean-station.org#33) I learned that arbitrary_self_types isn't needed for &Arc<Self>. After removing it, everything still compiles correctly. 😁

That was the most valuable nightly feature, so with that out of the way I'm happy to remove the few other minor conveniences and move over to stable!

jeremyBanks added a commit that referenced this issue Feb 22, 2020
@jeremyBanks
switch rust-toolchain over to stable
f1018dc 
no behaviour changes, minor meaningful code changes, but a bunch
of formatting changes because we were using nightly-only rustfmt
options.

resovles #228
github-actions bot pushed a commit that referenced this issue Feb 22, 2020
@jeremyBanks
OG
e9627b2 
sorry clippy

stop testing on nightly

switch rust-toolchain over to stable

no behaviour changes, minor meaningful code changes, but a bunch
of formatting changes because we were using nightly-only rustfmt
options.

resovles #228

bump rust-toolchain to nightly-2020-02-21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.6
Development

No branches or pull requests
1 participant
@jeremyBanks