This repository has been archived by the owner on Dec 9, 2020. It is now read-only.
Work in Progress #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me = client.get_me()
sandbox = client.get_room(11540)
with sandbox.messages() as messages:
sandbox.send_message("hello worl")
for message in messages:
if message.owner is me:
assert my_message.content == "hello worl"
ref Manishearth#65, ref Manishearth#52, ref Manishearth#43
The message scraping methods haven't been moved yet; they'll need to be disentangled from Message logic. PEP-8 formatting changes in browser. ref Manishearth#59
Adds user_id/user_name attributes to browser.
We had some function that did this previously. If we want it in the future, this decorator is a cleaner approach than repeating it in every function.
Made pinning/starring methods more intelligent with known attributes. ref Manishearth#59
They still have no scraping implemented for unknown values. ref Manishearth#52, Manishearth#65
Fixes a syntax error in chat example.
Moves some logic from client to room. Adds simple docstrings with epydoc annotations to public fields and methods of Client. Also adds epydoc as a dev dependency, and adds `make epydocs`. It probably isn't necessary to add this documentation to our internal methods, and I won't bother with browser for now, but I think it's useful to have for our user-friendly interface. (Both for users directly and through IDEs that recognize the type annotations, like PyCharm CE.) resolves Manishearth#52 - let's forget about slugs and message sets for now. We can reply to messages and a weak set of current messages might be pointless. ref Manishearth#65, Manishearth#43 - event/message iterators/contexts are still outstanding.
resolves Manishearth#43, resolves Manishearth#65
banksJeremy
pushed a commit
that referenced
this pull request
May 15, 2014
jeremyBanks
pushed a commit
that referenced
this pull request
Mar 14, 2017
Documentation #1: _utils.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client.get_me()