Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib/parseMapping): resolve alias check error on same field #386

Merged
merged 4 commits into from
Dec 2, 2022
Merged

fix(lib/parseMapping): resolve alias check error on same field #386

merged 4 commits into from
Dec 2, 2022

Conversation

ole3021
Copy link
Contributor

@ole3021 ole3021 commented Dec 1, 2022

Original Issue

  • Fix by allow check alias name is same to the field name.

@naorpeled
Copy link
Collaborator

Hey @ole3021,
first of all thanks for creating this PR, you're awesome 😎

Can you please add tests that validate this?

@naorpeled naorpeled linked an issue Dec 1, 2022 that may be closed by this pull request
receive "Error: 'alias' must be a unique string" when overriding created default value #85
Closed
@ole3021
Copy link
Contributor Author

ole3021 commented Dec 1, 2022

@naorpeled Just add a use case test, please have a check. Thx.

@naorpeled
Copy link
Collaborator

@naorpeled Just add a use case test, please have a check. Thx.

Awesome, will take a look soon, thanks!

naorpeled
naorpeled approved these changes Dec 1, 2022
View reviewed changes
src/lib/parseMapping.ts Outdated Show resolved Hide resolved
@naorpeled
Copy link
Collaborator

@ole3021 great PR,
left some nit comments, once they're addressed will get this merged 😎

ole3021 and others added 2 commits December 2, 2022 16:05
@ole3021 @naorpeled
Update src/__tests__/parse-alias.unit.test.ts
bb386c4 
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
@ole3021 @naorpeled
Update src/lib/parseMapping.ts
75221f5 
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
@naorpeled naorpeled changed the title fix alias check error by avoid the field itself alias. fix(lib/parseMapping): resolve alias check error on same field Dec 2, 2022
@naorpeled naorpeled merged commit fa97f24 into jeremydaly:main Dec 2, 2022
This was referenced Dec 16, 2022
Merged
Merged
Draft
@naorpeled naorpeled mentioned this pull request Feb 17, 2023
Merged
@naorpeled naorpeled mentioned this pull request Mar 9, 2023
Merged
@naorpeled naorpeled mentioned this pull request Apr 1, 2023
Draft
This was referenced Apr 8, 2023
Merged
Merged
Merged
Merged
@naorpeled naorpeled mentioned this pull request Apr 21, 2023
Merged
@naorpeled naorpeled mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naorpeled naorpeled naorpeled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

receive "Error: 'alias' must be a unique string" when overriding created default value
2 participants
@ole3021 @naorpeled