Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multi-value query parameters #72

Closed
jeremydaly opened this issue Nov 20, 2018 · 5 comments
Closed

Add support for multi-value query parameters #72

jeremydaly opened this issue Nov 20, 2018 · 5 comments
Labels
enhancement
Milestone
v0.10

Comments

@jeremydaly
Copy link
Owner

AWS recently announced support for multi-value parameters in Amazon API Gateway (https://aws.amazon.com/blogs/compute/support-for-multi-value-parameters-in-amazon-api-gateway/).
@jeremydaly jeremydaly added this to the v0.10 milestone Dec 5, 2018
@jeremydaly
Copy link
Owner Author

A PR for this was merged into the v0.10.0 branch.

@jeremydaly
Copy link
Owner Author

jeremydaly commented Dec 5, 2018 •
edited
Loading

  • Test cases required

@GuidoNebiolo
Copy link

opened a new pull request adding test cases

jeremydaly added a commit that referenced this issue Dec 22, 2018
@jeremydaly
additional test cases for #72
176597b
@jeremydaly
Copy link
Owner Author

I broke this out into res.query and res.multiValueQuery so that devs don't need to test for arrays. API Gateway sets the multiValueQueryStringParameters for ALL query string parameters, so you can always access the latter as arrays.

@jeremydaly
Copy link
Owner Author

Added simulated support for ALB with "multi-value support" turned off as well. This will make sure that res.multiValueQuery is always populated regardless of the interface, giving devs consistent access to array-based vales for query string parameters.

jeremydaly added a commit that referenced this issue Dec 23, 2018
@jeremydaly
add multi-value support detection for #72 and #73, simulate multiValu…
09f6596 
…eQuery when necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.10
Development

No branches or pull requests
2 participants
@jeremydaly @GuidoNebiolo