Psych 5.1.1 fails to load on JRuby 9.x #655

jsvd · 2023-10-11T13:43:14Z

[EDIT] the issue also happens with 9.3.11.0 and the latest daily snapshot of 9.4.4.0

The new psych gem version 5.1.1 doesn't work correctly when installed in JRuby ~~, I've tried only with 9.4.2.0 so far~~:

/tmp ❯ tar -zxf ~/Downloads/jruby-dist-9.4.2.0-bin.tar.gz

/tmp ❯ cd jruby-9.4.2.0 

/tmp/jruby-9.4.2.0 ❯ bin/jruby -v
jruby 9.4.2.0 (3.1.0) 2023-03-08 90d2913fda OpenJDK 64-Bit Server VM 17.0.4.1+1 on 17.0.4.1+1 +jit [arm64-darwin]

/tmp/jruby-9.4.2.0 ❯ bin/jruby -S gem install psych
Fetching psych-5.1.1-java.gem
  jar dependencies for psych-5.1.1-java.gemspec . . .
Installing gem 'ruby-maven' . . .
Fetching ruby-maven-3.3.13.gem
Fetching ruby-maven-libs-3.3.9.gem
Successfully installed ruby-maven-libs-3.3.9
Successfully installed ruby-maven-3.3.13
Parsing documentation for ruby-maven-libs-3.3.9
Installing ri documentation for ruby-maven-libs-3.3.9
Parsing documentation for ruby-maven-3.3.13
Installing ri documentation for ruby-maven-3.3.13
Done installing documentation for ruby-maven-libs, ruby-maven after 0 seconds
Parsing documentation for ruby-maven-3.3.13
Parsing documentation for ruby-maven-libs-3.3.9
Done installing documentation for ruby-maven, ruby-maven-libs after 0 seconds

using maven for the first time results in maven
downloading all its default plugin and can take time.
as those plugins get cached on disk and further execution
of maven is much faster then the first time.

2023-10-11T14:39:15.073+01:00 [main] WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable.
      org.snakeyaml:snakeyaml-engine:2.7:compile
Successfully installed psych-5.1.1-java
Parsing documentation for psych-5.1.1-java
Installing ri documentation for psych-5.1.1-java
Done installing documentation for psych after 0 seconds
1 gem installed

/tmp/jruby-9.4.2.0 ❯ bin/jruby -S gem install psych
NameError: cannot load (ext) (org.jruby.ext.psych.PsychLibrary)
          load_ext at org/jruby/ext/jruby/JRubyUtilLibrary.java:216
            <main> at /private/tmp/jruby-9.4.2.0/lib/ruby/gems/shared/gems/psych-5.1.1-java/lib/psych.rb:7
           require at org/jruby/RubyKernel.java:1057
           require at /private/tmp/jruby-9.4.2.0/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:85
         load_yaml at /private/tmp/jruby-9.4.2.0/lib/ruby/stdlib/rubygems.rb:610
         load_file at /private/tmp/jruby-9.4.2.0/lib/ruby/stdlib/rubygems/config_file.rb:346
        initialize at /private/tmp/jruby-9.4.2.0/lib/ruby/stdlib/rubygems/config_file.rb:189
               new at org/jruby/RubyClass.java:904
  do_configuration at /private/tmp/jruby-9.4.2.0/lib/ruby/stdlib/rubygems/gem_runner.rb:71
               run at /private/tmp/jruby-9.4.2.0/lib/ruby/stdlib/rubygems/gem_runner.rb:33
            <main> at /private/tmp/jruby-9.4.2.0/bin/jgem:21
              load at org/jruby/RubyKernel.java:1091
            <main> at /private/tmp/jruby-9.4.2.0/bin/gem:4

The text was updated successfully, but these errors were encountered:

The new psych 5.1.1 gem seems to not work when installed in JRuby 9.4 (used in main). This change pins the version back to 5.1.0 until ruby/psych#655 is sorted.

The new psych 5.1.1 gem seems to not work when installed in JRuby 9.4 (used in main). This change pins the version back to 5.1.0 until ruby/psych#655 is sorted. (cherry picked from commit 401d166)

The new psych 5.1.1 gem seems to not work when installed in JRuby 9.4 (used in main). This change pins the version back to 5.1.0 until ruby/psych#655 is sorted. (cherry picked from commit 401d166) Co-authored-by: João Duarte <jsvd@users.noreply.github.com>

jsvd · 2023-10-13T10:22:37Z

@headius sorry for the ping here, just wanted to raise awareness of the impact of the changes between 5.1.0 and 5.1.1.

dometto · 2023-10-13T16:25:04Z

It looks like 5.1.1 was released to fix an issue on JRuby in 5.1.0, but that the Java artifacts were not rebuilt. PsychLibrary.java is the exact same file on both versions of psych:

$ md5sum ~/.rvm/gems/jruby-9.4.0.0@gollum/gems/psych-5.1.0-java/ext/java/org/jruby/ext/psych/PsychLibrary.java
445fce33df726a26317e2bbab2b1bee3

md5sum  ~/.rvm/gems/jruby-9.4.0.0/gems/psych-5.1.1-java/ext/java/org/jruby/ext/psych/PsychLibrary.java 
445fce33df726a26317e2bbab2b1bee

(This occurred to me because I remembered it happening before: #598)

headius · 2023-10-13T16:45:56Z

@dometto Oh interesting! This makes some sense; if the Java bits were not updated, then they are not referencing the new path to the properties file. That would explain why my stepping through the code was off by several lines; it was the wrong code!

@hsbt I think we need a new release that includes updated JRuby bits. They did not get rebuilt for 5.1.1 so they are broken in that release. Rebuilding them requires JRuby 9.4.1.0. I updated CI to use 9.4.1.0 for testing until we can fully drop support for the older Region API in Joni.

headius · 2023-10-13T16:52:46Z

@hsbt Perhaps we can also chat about how to make this easier in the future, perhaps with a CI job to cleanly build all the gem targets every push.

**What problem is this PR intended to solve?** drop minitest-reporters, because even having it in the Gemfile messes with minitest-parallel_fork, sigh. For context, see: - minitest-reporters/minitest-reporters#247 - jeremyevans/minitest-parallel_fork#3 Also, avoid psych 5.1.1 because of ruby/psych#655

hsbt · 2023-10-16T01:39:40Z

@headius I built psych-5.1.1 with JRuby 9.4.3.0. Should I rebuild it with JRuby 9.4.1.0? I'm not sure what's the problem of this case.

headius · 2023-10-16T11:41:11Z

@hsbt Perhaps you were not on master HEAD? Looking at comments above, PsychParser.java did not change between the two releases. I am confused as well.

hsbt · 2023-10-16T11:52:43Z

I'm also not sure why they are same.

I'll release 5.1.1.1 with this:

$ md5sum ~/.local/share/gem/gems/psych-5.1.1-java/ext/java/org/jruby/ext/psych/PsychParser.java
1b689b170835a983f5fe3cc5da1e0d09  /Users/hsbt/.local/share/gem/gems/psych-5.1.1-java/ext/java/org/jruby/ext/psych/PsychParser.java

hsbt · 2023-10-16T11:56:46Z

Released https://github.com/ruby/psych/releases/tag/v5.1.1.1

headius · 2023-10-16T12:29:00Z

@hsbt @jsvd @dometto @olleolleolle The new gem appears to work correctly! Please verify!

olleolleolle · 2023-10-16T12:35:49Z

Confirmed that I could run my test suite, and release https://rubygems.org/gems/gemstash/versions/2.7.1-java with it. Thanks!

A recent release of Psych was not compatible with JRuby. You can learn more about the issue here: ruby/psych#655

ruby/psych#655 has been fixed with the release of 5.1.1.1

ruby/psych#655 has been fixed with the release of 5.1.1.1 (cherry picked from commit 6046402)

ruby/psych#655 has been fixed with the release of 5.1.1.1 (cherry picked from commit 6046402) Co-authored-by: João Duarte <jsvd@users.noreply.github.com>

I think ruby/psych#655 was resolved long ago

* Allow custom Redis instance for tests You probably don't want the tests to use the same Redis you use for any app development. Maybe you want to use Docker with custom port: docker run --rm -it -p 16379:6379 redis:6 * Run sentry-resque specs without Rails Tests and fixes #2243 * Run with latest `psych` I think ruby/psych#655 was resolved long ago * Note `constantize` sentry-resque fix in CHANGELOG

jsvd added a commit to jsvd/logstash that referenced this issue Oct 11, 2023

pin psych 5.1.1 due to ruby/psych#655

31c4581

jsvd mentioned this issue Oct 11, 2023

pin psych 5.1.0 due to ruby/psych#655 elastic/logstash#15433

Merged

github-actions bot mentioned this issue Oct 11, 2023

Backport PR #15433 to 8.11: pin psych 5.1.0 due to ruby/psych#655 elastic/logstash#15434

Merged

jsvd changed the title ~~Psych 5.1.1 fails to load on JRuby 9.4.2.0~~ Psych 5.1.1 fails to load on JRuby 9.x Oct 11, 2023

olleolleolle mentioned this issue Oct 12, 2023

Reinstate nonfunctional --no-daemonize, --daemonize options that warn rubygems/gemstash#381

Merged

mvz mentioned this issue Oct 13, 2023

Use ruby-setup's native caching ActsAsParanoid/acts_as_paranoid#318

Merged

This was referenced Oct 13, 2023

Psych issue when running bundle cmd on a rails generator project jruby/jruby#7962

Closed

Pin psych gem 5.1.0 bensheldon/good_job#1108

Merged

dometto mentioned this issue Oct 13, 2023

Change links to buttons and use onclick to navigate. Improves keyboard navigation and accessibility. gollum/gollum#2003

Merged

st0012 mentioned this issue Oct 14, 2023

Fix JRuby build by pinning pysch to 5.1.0 getsentry/sentry-ruby#2142

Merged

flavorjones mentioned this issue Oct 14, 2023

dep: drop minitest-reporters, avoid psych 5.1.1 sparklemotion/nokogiri#3002

Merged

kares mentioned this issue Oct 16, 2023

Bundler prevents loading psych under JRuby rubygems/rubygems#7064

Closed

headius closed this as completed Oct 16, 2023

benjaminwil added a commit to gollum/gollum that referenced this issue Oct 16, 2023

Update JRuby used by GitHub Actions

77a57c2

A recent release of Psych was not compatible with JRuby. You can learn more about the issue here: ruby/psych#655

benjaminwil mentioned this issue Oct 16, 2023

Improve and localize the "edit" view partial gollum/gollum#2010

Merged

mevatron mentioned this issue Oct 17, 2023

psych 5.1.1 causing logstash to crash with logstash-filter-translate@3.4.2 logstash-plugins/logstash-filter-translate#100

Closed

andrehjr mentioned this issue Oct 17, 2023

Bundler cannot load psych under JRuby when loading the gemspec (JRuby however can load psych outside of bundler) rubygems/rubygems#7073

Closed

jsvd added a commit to elastic/logstash that referenced this issue Oct 18, 2023

Remove pinning of psych 5.1.0

ae8d840

ruby/psych#655 has been fixed with the release of 5.1.1.1

jsvd mentioned this issue Oct 18, 2023

Remove pinning of psych 5.1.0 elastic/logstash#15474

Merged

jsvd added a commit to elastic/logstash that referenced this issue Oct 18, 2023

Remove pinning of psych 5.1.0 (#15474)

6046402

ruby/psych#655 has been fixed with the release of 5.1.1.1

github-actions bot mentioned this issue Oct 18, 2023

Backport PR #15474 to 8.11: Remove pinning of psych 5.1.0 elastic/logstash#15476

Merged

github-actions bot pushed a commit to elastic/logstash that referenced this issue Oct 18, 2023

Remove pinning of psych 5.1.0 (#15474)

81c1dc2

ruby/psych#655 has been fixed with the release of 5.1.1.1 (cherry picked from commit 6046402)

jsvd added a commit to elastic/logstash that referenced this issue Oct 18, 2023

Remove pinning of psych 5.1.0 (#15474) (#15476)

446e60f

ruby/psych#655 has been fixed with the release of 5.1.1.1 (cherry picked from commit 6046402) Co-authored-by: João Duarte <jsvd@users.noreply.github.com>

dentarg added a commit to dentarg/raven-ruby that referenced this issue Feb 17, 2024

Run with latest psych

293f40f

I think ruby/psych#655 was resolved long ago

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Psych 5.1.1 fails to load on JRuby 9.x #655

Psych 5.1.1 fails to load on JRuby 9.x #655

jsvd commented Oct 11, 2023 •

edited

Loading

jsvd commented Oct 13, 2023

dometto commented Oct 13, 2023 •

edited

Loading

headius commented Oct 13, 2023

headius commented Oct 13, 2023

hsbt commented Oct 16, 2023

headius commented Oct 16, 2023

hsbt commented Oct 16, 2023

hsbt commented Oct 16, 2023

headius commented Oct 16, 2023

olleolleolle commented Oct 16, 2023

Psych 5.1.1 fails to load on JRuby 9.x #655

Psych 5.1.1 fails to load on JRuby 9.x #655

Comments

jsvd commented Oct 11, 2023 • edited Loading

jsvd commented Oct 13, 2023

dometto commented Oct 13, 2023 • edited Loading

headius commented Oct 13, 2023

headius commented Oct 13, 2023

hsbt commented Oct 16, 2023

headius commented Oct 16, 2023

hsbt commented Oct 16, 2023

hsbt commented Oct 16, 2023

headius commented Oct 16, 2023

olleolleolle commented Oct 16, 2023

jsvd commented Oct 11, 2023 •

edited

Loading

dometto commented Oct 13, 2023 •

edited

Loading