Avoid method redefinition warnings in verbose warning mode

Use alias hack to avoid most of the warnings.

Silence warnings in mail, hanna-nouveau, and minjs gems in the
spec_w rake task.

CHANGELOG

@@ -1,5 +1,7 @@
 = master
 
+* Avoid method redefinition warnings in verbose warning mode (jeremyevans)
+
 * Make typecast_params.convert! handle explicit nil values the same as missing values (jeremyevans)
 
 = 3.38.0 (2020-11-16)

lib/roda.rb

@@ -114,6 +114,7 @@ def define_roda_method(meth, expected_arity, &block)
                 alias_method meth, temp_method
                 undef_method temp_method
                 private meth
+                alias_method meth, meth
                 meth = :"#{meth}_arity"
               elsif required_args > 1
                 b = block
@@ -144,6 +145,7 @@ def define_roda_method(meth, expected_arity, &block)
 
           define_method(meth, &block)
           private meth
+          alias_method meth, meth
 
           if arity_meth
             required_args, optional_args, rest, keyword = _define_roda_method_arg_numbers(instance_method(meth))
@@ -167,6 +169,7 @@ def define_roda_method(meth, expected_arity, &block)
               send(meth, *a)
             end
             private arity_meth
+            alias_method arity_meth, arity_meth
           end
 
           call_meth
@@ -199,6 +202,7 @@ def freeze
 
                 private
 
+                alias set_default_headers set_default_headers
                 def set_default_headers
                   @headers['Content-Type'] ||= 'text/html'
                 end
@@ -403,6 +407,7 @@ def def_roda_before
               class_eval("def _roda_before; #{meths.join(';')} end", __FILE__, __LINE__)
             end
             private :_roda_before
+            alias_method :_roda_before, :_roda_before
           end
         end
 

lib/roda/plugins/default_headers.rb

@@ -33,6 +33,7 @@ def self.configure(app, headers={})
             response_class.class_eval(<<-END, __FILE__, __LINE__+1)
               private
 
+              alias set_default_headers set_default_headers
               def set_default_headers
                 h = @headers
                 #{headers.map{|k,v| "h[#{k.inspect}] ||= #{v.inspect}"}.join('; ')}

lib/roda/plugins/mail_processor.rb

@@ -476,6 +476,8 @@ def match_#{field}(address)
 
         undef_method :match_rcpt
         undef_method :match_text
+        undef_method :match_body
+        undef_method :match_subject
 
         # Same as +header+, but also mark the message as being handled.
         def handle_header(key, value=nil)

lib/roda/plugins/type_routing.rb

@@ -141,6 +141,7 @@ def self.configure(app, opts = {})
           app::RodaRequest.send(:define_method, type) do |&block|
             on_type(type, &block)
           end
+          app::RodaRequest.send(:alias_method, type, type)
         end
 
         app.opts[:type_routing] = config.freeze

spec/spec_helper.rb

@@ -2,7 +2,8 @@
 
 if ENV['WARNING']
   require 'warning'
-  Warning.ignore([:missing_ivar, :method_redefined], File.dirname(File.dirname(__FILE__)))
+  Warning.ignore(:missing_ivar, File.dirname(File.dirname(__FILE__)))
+  Warning.ignore(%r{gems/(mail|hanna-nouveau|minjs)-\d})
   Warning.dedup if Warning.respond_to?(:dedup)
 end