Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis config for testing against multiple ruby versions #3

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

PikachuEXE
Copy link
Contributor

Also add missing dependencies

@PikachuEXE
Copy link
Contributor Author

The build is green

@jeremyevans jeremyevans merged commit 0cc91a9 into jeremyevans:master Mar 21, 2017
@jeremyevans
Copy link
Owner

Thanks for the patch! I added another patch that modifies the travis configuration to be more like my other projects, and starts testing on JRuby, but it is good to add CI at this point.

@PikachuEXE PikachuEXE deleted the feature/add-ci branch March 22, 2017 01:45
@PikachuEXE
Copy link
Contributor Author

I was trying to change eval to something else but failed
Got many things that cannot be fetched by module_eval
(ARGF.class, Complex::compatible)

Also some constants are undefined until file required (like Date)

@jeremyevans
Copy link
Owner

The things that cannot be fetched by eval issue could be handled by removing constant names from the module_names/*.txt file. Those files were produced by something like: ruby -e 'ObjectSpace.each_object(Module){|e| p e}'. The code already uses defined? to check if the constants actually exist.

In terms of the Date issue, it's only handled on ruby 2.0 and 2.1, and that's because it is available by default in those versions. I guess I could have used --disable-gems (it's defined by rubygems in those versions), but then it doesn't really reflect what ruby loads by default.

Anyway, I don't think this is a bug, though it could certainly be implemented differently.

@PikachuEXE
Copy link
Contributor Author

Might worth mentioning how those lists of constants are obtained in README (ruby -e 'ObjectSpace.each_object(Module){|e| p e}')

@jeremyevans
Copy link
Owner

Good idea, I've pushed a README update, as well as a Rakefile task that can generate the files for new ruby versions.

@PikachuEXE
Copy link
Contributor Author

Great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants