Add Sequel::Model.dataset? method
#1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this idea is good, but please rename the method |
Because `.dataset` raises error if there is no dataset, and there is no quiet way to check dataset existing, except `rescue`. Useful for multiple-inherited abstract classes. Reference: https://groups.google.com/d/msg/sequel-talk/OG5ti9JAJIE/G8ncUsT4BAAJ
AlexWayfer
force-pushed
the
add_model_dataset_predictive_method
branch
from
e25fd75
to
02f3a01
Compare
Okay. I thought it's deprecated because of RuboCop, but it's not. I can make an alias, but I think you don't want this. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
.datasetraises error if there is no dataset,and there is no quiet way to check dataset existing, except
rescue.Useful for multiple-inherited abstract classes.
Reference: https://groups.google.com/d/msg/sequel-talk/OG5ti9JAJIE/G8ncUsT4BAAJ