Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

has_key? deprecated? #3224

Closed
Aqualon opened this issue Jun 15, 2016 · 3 comments
Closed

has_key? deprecated? #3224

Aqualon opened this issue Jun 15, 2016 · 3 comments

Comments

@Aqualon
Copy link
Contributor

Aqualon commented Jun 15, 2016

The Style/DeprecatedHashMethods cop says, that has_key? is deprecated in favor of key?, citing a four year old message from @matz: http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/43765

The ruby 2.3.1 documentation does not mention the deprecation and has_key? is mentioned all over the place, even as example for key?: http://ruby-doc.org/core-2.3.1/Hash.html#method-i-key-3F

So is this really deprecated?
@tejasbubane
Copy link
Contributor

Looking at the doc and source, seems like key? is just an alias of has_key?. Similarly value? is an alias of has_value?.

@mikegee
Copy link
Contributor

mikegee commented Jun 15, 2016

If Matz said it is deprecated, we should assume it won't be in Ruby 3. The only thing missing is a note in the Ruby documentation.

@matz
Copy link

matz commented Jun 15, 2016

Although I prefer key? and recommend to use it over has_key?, it is not going to be removed, even in Ruby3.

@tejasbubane tejasbubane mentioned this issue Jun 15, 2016
Merged
9 tasks
tejasbubane added a commit to tejasbubane/rubocop that referenced this issue Jun 16, 2016
@tejasbubane
Rename Style/DeprecatedHashMethods to Style/PreferredHashMethods
e205151 
Fixes rubocop#3224

As stated by Matz in the discussion in rubocop#3224, the methods
`Hash#has_key?` and `Hash#has_value?` will not be deprecated. Hence
rename the cop and corresponding messages to not use the word deprecated.
bbatsov pushed a commit that referenced this issue Jun 17, 2016
@tejasbubane @bbatsov
Rename Style/DeprecatedHashMethods to Style/PreferredHashMethods (#…
37a39d6 
…3226)

Fixes #3224

As stated by Matz in the discussion in #3224, the methods
`Hash#has_key?` and `Hash#has_value?` will not be deprecated. Hence
rename the cop and corresponding messages to not use the word deprecated.
bastelfreak added a commit to bastelfreak/modulesync_config that referenced this issue Jun 30, 2016
@bastelfreak
rename cop to PreferredHashMethods
aa8da7d 
 Rename Style/DeprecatedHashMethods to Style/PreferredHashMethods. this
 change happend in the last rubocop release
 rubocop/rubocop#3224
@bastelfreak bastelfreak mentioned this issue Jun 30, 2016
Merged
@mentero mentero mentioned this issue Aug 18, 2016
Merged
@roberts1000 roberts1000 mentioned this issue Aug 29, 2016
Closed
Neodelf pushed a commit to Neodelf/rubocop that referenced this issue Oct 15, 2016
@tejasbubane @Neodelf
Rename Style/DeprecatedHashMethods to Style/PreferredHashMethods (r…
52ccff6 
…ubocop#3226)

Fixes rubocop#3224

As stated by Matz in the discussion in rubocop#3224, the methods
`Hash#has_key?` and `Hash#has_value?` will not be deprecated. Hence
rename the cop and corresponding messages to not use the word deprecated.
yakschuss added a commit to yakschuss/guides that referenced this issue Oct 30, 2016
@yakschuss
Change DeprecatedHashMethods to PreferredHashMethods
7b4fa4d 
This change was officially made in June, and raises a warning when
running rubocop.

"Warning: unrecognized cop Style/DeprecatedHashMethods"

rubocop/rubocop#3224
@yakschuss yakschuss mentioned this issue Oct 30, 2016
Closed
geoffharcourt pushed a commit to thoughtbot/guides that referenced this issue Jan 12, 2017
@yakschuss @geoffharcourt
Change DeprecatedHashMethods to PreferredHashMethods
224f737 
This change was officially made in June, and raises a warning when
running rubocop.

"Warning: unrecognized cop Style/DeprecatedHashMethods"

rubocop/rubocop#3224
@info-rchitect info-rchitect mentioned this issue Aug 8, 2017
Closed
@ChrisBr ChrisBr mentioned this issue Jan 2, 2018
Merged
@AlexWayfer AlexWayfer mentioned this issue May 17, 2018
Merged
@tekin tekin mentioned this issue Nov 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikegee @matz @tejasbubane @Aqualon